[PATCH v4 0/1] MR3392: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().

[Zhao Yi (＠Zhaoyi)]

Same as MR !2394

Signed-off-by: Zhaoyi zhaoyi(a)uniontech.com

--
  v4: comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

[PATCH v4 1/1] comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().

[Zhaoyi]

From: Zhaoyi <zhaoyi(a)uniontech.com>

Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com>
---
 dlls/comctl32/listview.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index 750e447dbef..f942bd0906d 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -5590,6 +5590,8 @@ static BOOL LISTVIEW_DeleteAllItems(LISTVIEW_INFO *infoPtr, BOOL destroy)
         LISTVIEW_UpdateScroll(infoPtr);
     }
     LISTVIEW_InvalidateList(infoPtr);
+    /* bNoItemMetrics should be reset to TRUE after calling LISTVIEW_DeleteAllItems() */
+    infoPtr->bNoItemMetrics = TRUE;
     
     return TRUE;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3392

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c:
> LISTVIEW_UpdateScroll(infoPtr);
>      }
>      LISTVIEW_InvalidateList(infoPtr);
> +    /* bNoItemMetrics should be reset to TRUE after calling LISTVIEW_DeleteAllItems() */

I don't think this line of comment is necessary. The code is pretty clear.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3392#note_40299

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c:
> LISTVIEW_UpdateScroll(infoPtr);
>      }

You don't need to sign off your patches anymore now that we use Gitlab approvals. Having one is harmless though. Just don't forget to put a space between your first name and last name.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3392#note_40300

[Nikolay Sivov (＠nsivov)]

Commit message needs to describe the purpose of the change, not to duplicate what's obviously seen from the change itself.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3392#note_40301