[PATCH v2 0/1] MR4790: msvcp140_2: Implement __std_smf_hypot3.

[Alex Henrie (＠alexhenrie)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56078

--
  v2: msvcp140_2: Implement __std_smf_hypot3.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4790

[PATCH v2 1/1] msvcp140_2: Implement __std_smf_hypot3.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56078
---
 dlls/msvcp140_2/Makefile.in     |  3 +++
 dlls/msvcp140_2/math.c          | 26 ++++++++++++++++++++++++++
 dlls/msvcp140_2/msvcp140_2.spec |  2 +-
 3 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 dlls/msvcp140_2/math.c

diff --git a/dlls/msvcp140_2/Makefile.in b/dlls/msvcp140_2/Makefile.in
index 5b4865db844..0f75819198f 100644
--- a/dlls/msvcp140_2/Makefile.in
+++ b/dlls/msvcp140_2/Makefile.in
@@ -1 +1,4 @@
 MODULE       = msvcp140_2.dll
+
+SOURCES = \
+	math.c
diff --git a/dlls/msvcp140_2/math.c b/dlls/msvcp140_2/math.c
new file mode 100644
index 00000000000..d4313beeae4
--- /dev/null
+++ b/dlls/msvcp140_2/math.c
@@ -0,0 +1,26 @@
+/*
+ * Special math functions
+ *
+ * Copyright 2024 Alex Henrie
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+ */
+
+#include <math.h>
+
+double __cdecl __std_smf_hypot3(double x, double y, double z)
+{
+    return hypot(hypot(x, y), z);
+}
diff --git a/dlls/msvcp140_2/msvcp140_2.spec b/dlls/msvcp140_2/msvcp140_2.spec
index c59da9aba9c..06984ebb784 100644
--- a/dlls/msvcp140_2/msvcp140_2.spec
+++ b/dlls/msvcp140_2/msvcp140_2.spec
@@ -28,7 +28,7 @@
 @ stub __std_smf_expintf
 @ stub __std_smf_hermite
 @ stub __std_smf_hermitef
-@ stub __std_smf_hypot3
+@ cdecl __std_smf_hypot3(double double double)
 @ stub __std_smf_hypot3f
 @ stub __std_smf_laguerre
 @ stub __std_smf_laguerref
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4790

[Piotr Caban (＠piotr)]

The patch looks good for me. I guess it should wait until code-freeze ends. Is that right?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4790#note_56836

[Piotr Caban (＠piotr)]

I've created !4871 that contains updated version of your patch. It also adds some tests.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4790#note_57973

[PATCH v2 0/1] MR4790: msvcp140_2: Implement __std_smf_hypot3. - closed

[Alex Henrie (＠alexhenrie)]

This merge request was closed by Alex Henrie.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4790