[PATCH 0/1] MR5410: mfreadwrite/reader: Avoid accessing an invalid stream index.

[Rémi Bernon]

Fixes d6c9ac94d2fc92d86639e74699ef470b1d8a9861.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5410

[PATCH 1/1] mfreadwrite/reader: Avoid accessing an invalid stream index.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

Fixes d6c9ac94d2fc92d86639e74699ef470b1d8a9861.
---
 dlls/mfreadwrite/reader.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/mfreadwrite/reader.c b/dlls/mfreadwrite/reader.c
index b77b5f9c538..a8e022c9faa 100644
--- a/dlls/mfreadwrite/reader.c
+++ b/dlls/mfreadwrite/reader.c
@@ -2361,7 +2361,6 @@ static HRESULT WINAPI src_reader_GetServiceForStream(IMFSourceReaderEx *iface, D
         REFIID riid, void **object)
 {
     struct source_reader *reader = impl_from_IMFSourceReaderEx(iface);
-    struct media_stream *stream = &reader->streams[index];
     IUnknown *obj = NULL;
     HRESULT hr = S_OK;
 
@@ -2382,7 +2381,7 @@ static HRESULT WINAPI src_reader_GetServiceForStream(IMFSourceReaderEx *iface, D
 
             if (index >= reader->stream_count)
                 hr = MF_E_INVALIDSTREAMNUMBER;
-            else if (!(obj = (IUnknown *)stream->transform_service))
+            else if (!(obj = (IUnknown *)reader->streams[index].transform_service))
                 hr = E_NOINTERFACE;
             break;
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5410

[Rémi Bernon]

Anything wrong here?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5410#note_66662

[PATCH 0/1] MR5410: mfreadwrite/reader: Avoid accessing an invalid stream index. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5410