[PATCH 0/1] MR1917: [PATCH] shell32/tests: Workaround moving cursor to (0,0) coordinates.

[Gabriel Ivăncescu]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1917

[PATCH 1/1] shell32/tests: Workaround moving cursor to (0,0) coordinates.

[Gabriel Ivăncescu]

From: Gabriel Ivăncescu <gabrielopcode(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54090
Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com>
---
 dlls/shell32/tests/autocomplete.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/shell32/tests/autocomplete.c b/dlls/shell32/tests/autocomplete.c
index d0df5b225c1..a2a03bb24ac 100644
--- a/dlls/shell32/tests/autocomplete.c
+++ b/dlls/shell32/tests/autocomplete.c
@@ -828,10 +828,10 @@ START_TEST(autocomplete)
     ok(hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n");
     if (!hMainWnd) return;
 
-    /* Move the cursor away from the dropdown listbox */
+    /* Move the cursor away from the dropdown listbox; SetCursorPos(0, 0) does not seem to work */
     GetWindowRect(hMainWnd, &win_rect);
     GetCursorPos(&orig_pos);
-    SetCursorPos(win_rect.left, win_rect.top);
+    SetCursorPos(win_rect.left ? win_rect.left : 1, win_rect.top ? win_rect.top : 1);
 
     test_invalid_init();
     ac = test_init();
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1917

[PATCH 1/1] shell32/tests: Workaround moving cursor to (0,0) coordinates.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=128183

Your paranoid android.


=== w10pro64 (32 bit report) ===

shell32:
autocomplete.c:520: Test failed: Expected L"test\\foo\\bar\\", got L"test\\"

=== w1064_2qxl (64 bit report) ===

shell32:
autocomplete.c:636: Test failed: Expected L"www.ac", got L"www.a"
autocomplete.c:637: Test failed: AutoComplete DropDown not visible
autocomplete.c:637: Test failed: AutoComplete DropDown not visible
autocomplete.c:637: Test failed: Expected L"https://www.ac", got (null)
autocomplete.c:637: Test failed: AutoComplete DropDown not visible
autocomplete.c:637: Test failed: Expected L"http://www.add", got (null)
autocomplete.c:637: Test failed: AutoComplete DropDown not visible
autocomplete.c:637: Test failed: Expected L"www.ax", got (null)
autocomplete.c:637: Test failed: AutoComplete DropDown not visible

=== w1064_adm (64 bit report) ===

shell32:
autocomplete.c:513: Test failed: Expected L"test\\", got L""
autocomplete.c:520: Test failed: Expected L"test\\foo\\bar\\", got L""

=== w10pro64_en_AE_u8 (64 bit report) ===

shell32:
autocomplete.c:643: Test failed: Expected L"www.www.?", got L"www.w"