[PATCH 0/2] MR2526: Remove redundant NULL checks before free

[Michael Stefaniuc (＠mstefani)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2526

[PATCH 1/2] msdasql: Remove redundant NULL check before heap_free().

[Michael Stefaniuc]

From: Michael Stefaniuc <mstefani(a)winehq.org>

---
 dlls/msdasql/session.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/msdasql/session.c b/dlls/msdasql/session.c
index 588be365b72..3e6e5f2a0b3 100644
--- a/dlls/msdasql/session.c
+++ b/dlls/msdasql/session.c
@@ -693,8 +693,7 @@ static ULONG WINAPI command_Release(ICommandText *iface)
     if (!refs)
     {
         TRACE( "destroying %p\n", command );
-        if (command->properties)
-            heap_free(command->properties);
+        heap_free(command->properties);
         if (command->session)
             IUnknown_Release(command->session);
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/2526

[PATCH 2/2] windows.media.speech: Remove redundant NULL check before free().

[Michael Stefaniuc]

From: Michael Stefaniuc <mstefani(a)winehq.org>

---
 dlls/windows.media.speech/listconstraint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/windows.media.speech/listconstraint.c b/dlls/windows.media.speech/listconstraint.c
index ef0dff0e4d5..555f3b214e1 100644
--- a/dlls/windows.media.speech/listconstraint.c
+++ b/dlls/windows.media.speech/listconstraint.c
@@ -372,7 +372,7 @@ static HRESULT WINAPI constraint_factory_CreateWithTag( ISpeechRecognitionListCo
 
 error:
     if (impl->commands) IVector_HSTRING_Release(impl->commands);
-    if (impl) free(impl);
+    free(impl);
     return hr;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2526

[PATCH 2/2] windows.media.speech: Remove redundant NULL check before free().

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=131155

Your paranoid android.


=== debian11 (32 bit report) ===

qasf:
asfreader.c:233: Test failed: Got name L"Raw Audio 0".
asfreader.c:238: Test failed: Got id L"Raw Audio 0".

shell32:
progman_dde.c:274: Test failed: expected DMLERR_NO_ERROR, got 16393
progman_dde.c:275: Test failed: directory should not exist