[PATCH 0/1] MR8271: kernel32/tests: Don't call pNtCompareObjects in Windows 8.
Followup to bab2ccbbe8. [Test pattern page](https://test.winehq.org/data/patterns.html#kernel32:console) [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=158595). Hello @Alcaro, in the previous commit ` || skip_nt` was added while I don't see a relation to `pNtCompareObjects`, so I just replaced it by a check of this function pointer? Or should both be checked? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8271
From: Bernhard Übelacker <bernhardu(a)mailbox.org> Followup to bab2ccbbe8. --- dlls/kernel32/tests/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernel32/tests/console.c b/dlls/kernel32/tests/console.c index 9bccf9d290e..10d93faaf0f 100644 --- a/dlls/kernel32/tests/console.c +++ b/dlls/kernel32/tests/console.c @@ -5678,7 +5678,7 @@ static void test_FreeConsoleStd(void) {DETACHED_PROCESS, with_none, 0}, }; - if (!pVerifyConsoleIoHandle || skip_nt) + if (!pVerifyConsoleIoHandle || !pNtCompareObjects) { win_skip("Can't run test\n"); return; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/8271
@epo told me to https://gitlab.winehq.org/wine/wine/-/merge_requests/8162#note_104799, I didn't test very thoroughly, I just trusted him If this is needed to fix the tests, then LGTM -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8271#note_106119
participants (2)
-
Alfred Agrell (@Alcaro) -
Bernhard Übelacker