[PATCH v2 0/1] MR4664: wineps: Don't leak memory in error case (Coverity)

[Fabian Maurer (＠DarkShadow44)]

--
  v2: wineps: Don't leak memory in error case (Coverity)
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4664

[PATCH v2 1/1] wineps: Don't leak memory in error case (Coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

---
 dlls/wineps.drv/ps.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c
index 03c92aa00f0..59e245b9b6c 100644
--- a/dlls/wineps.drv/ps.c
+++ b/dlls/wineps.drv/ps.c
@@ -985,6 +985,12 @@ BOOL PSDRV_WriteDIBPatternDict(print_ctx *ctx, const BITMAPINFO *bmi, BYTE *bits
 	return FALSE;
     }
 
+    if (usage > 2)
+    {
+        FIXME("wrong usage: %d\n", usage);
+        return FALSE;
+    }
+
     w = bmi->bmiHeader.biWidth;
     h = abs_height;
 
@@ -1025,11 +1031,7 @@ BOOL PSDRV_WriteDIBPatternDict(print_ctx *ctx, const BITMAPINFO *bmi, BYTE *bits
         map[0] = GetTextColor( ctx->hdc );
         map[1] = GetBkColor( ctx->hdc );
     }
-    else
-    {
-        FIXME("wrong usage: %d\n", usage);
-        return FALSE;
-    }
+
     PSDRV_WriteRGB(ctx, map, 2);
     PSDRV_WriteIndexColorSpaceEnd(ctx);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4664

[PATCH v2 0/1] MR4664: wineps: Don't leak memory in error case (Coverity) - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4664