[PATCH 0/2] MR2784: Draft: kernel32/tests: Use win_skip() for missing APIs.
From: Francois Gouget <fgouget(a)codeweavers.com> --- dlls/kernel32/tests/console.c | 2 +- dlls/kernel32/tests/file.c | 2 +- dlls/kernel32/tests/process.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/kernel32/tests/console.c b/dlls/kernel32/tests/console.c index 5adce2d3f37..4aa293df4b8 100644 --- a/dlls/kernel32/tests/console.c +++ b/dlls/kernel32/tests/console.c @@ -3864,7 +3864,7 @@ static void test_GetConsoleFontInfo(HANDLE std_output) pGetNumberOfConsoleFonts = (void *)GetProcAddress(hmod, "GetNumberOfConsoleFonts"); if (!pGetNumberOfConsoleFonts) { - skip("GetNumberOfConsoleFonts is not available\n"); + win_skip("GetNumberOfConsoleFonts is not available\n"); return; } diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index 73ae75d52af..8492f0dea7f 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -914,7 +914,7 @@ static void test_CopyFile2(void) if (!pCopyFile2) { - skip("CopyFile2 is not available\n"); + win_skip("CopyFile2 is not available\n"); return; } diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 3c4a02e7cc8..f071268f0f0 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -2185,7 +2185,7 @@ static void test_IsWow64Process2(void) if (!pIsWow64Process2) { - skip("IsWow64Process2 is not available\n"); + win_skip("IsWow64Process2 is not available\n"); return; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2784
From: Francois Gouget <fgouget(a)codeweavers.com> --- dlls/kernelbase/tests/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernelbase/tests/process.c b/dlls/kernelbase/tests/process.c index b8c3bbb7276..2979af39551 100644 --- a/dlls/kernelbase/tests/process.c +++ b/dlls/kernelbase/tests/process.c @@ -49,7 +49,7 @@ static void test_CompareObjectHandles(void) if (!pCompareObjectHandles) { - skip("CompareObjectHandles is not available.\n"); + win_skip("CompareObjectHandles is not available.\n"); return; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2784
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=132564 Your paranoid android. === debian11 (32 bit report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11 (32 bit ar:MA report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11 (32 bit de report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11 (32 bit fr report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11 (32 bit he:IL report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11 (32 bit hi:IN report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11 (32 bit ja:JP report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11 (32 bit zh:CN report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11b (32 bit WoW report) === kernel32: file.c:917: Test failed: CopyFile2 is not available === debian11b (64 bit WoW report) === kernel32: file.c:917: Test failed: CopyFile2 is not available
participants (3)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Marvin