[PATCH 0/1] MR6405: winemapi: Don't write past the end of the argv array.

[Huw Davies (＠huw)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6405

[PATCH 1/1] winemapi: Don't write past the end of the argv array.

[Huw Davies]

From: Huw Davies <huw(a)codeweavers.com>

---
 dlls/winemapi/sendmail.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winemapi/sendmail.c b/dlls/winemapi/sendmail.c
index eea5ec318b9..94256300849 100644
--- a/dlls/winemapi/sendmail.c
+++ b/dlls/winemapi/sendmail.c
@@ -60,7 +60,7 @@ static void add_argument(struct args *args, const char *arg)
 {
     args->argv = realloc(args->argv, (args->count + 2) * sizeof(char *));
     args->argv[args->count++] = strdup(arg);
-    args->argv[args->count + 1] = NULL;
+    args->argv[args->count] = NULL;
 }
 
 static void add_target(struct args *args, ULONG class, const char *address)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6405

[Elizabeth Figura (＠zfigura)]

Oops, thanks for catching that.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6405#note_80534