[PATCH 0/1] MR5062: dsound: Simplify f_to_32.
Fixes clang warning: ``` ../dlls/dsound/dsound_convert.c:145:23: warning: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Wimplicit-const-int-float-conversion] if(value >= 1.f * 0x7FFFFFFF / 0x80000000U) /* this rounds to 1.f */ ~ ^~~~~~~~~~ ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5062
From: Jacek Caban <jacek(a)codeweavers.com> --- dlls/dsound/dsound_convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dsound/dsound_convert.c b/dlls/dsound/dsound_convert.c index 67344565860..bdd62c8e51f 100644 --- a/dlls/dsound/dsound_convert.c +++ b/dlls/dsound/dsound_convert.c @@ -142,7 +142,7 @@ static inline LONG f_to_32(float value) { if(value <= -1.f) return 0x80000000; - if(value >= 1.f * 0x7FFFFFFF / 0x80000000U) /* this rounds to 1.f */ + if(value >= 1.f) return 0x7FFFFFFF; return le32(lrintf(value * 0x80000000U)); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5062
This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5062
participants (3)
-
Huw Davies (@huw) -
Jacek Caban -
Jacek Caban (@jacek)