[PATCH 0/1] MR6434: msiexec: Don't quote property values if already quoted.

[Hans Leidekker (＠hans)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57024

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6434

[PATCH 1/1] msiexec: Don't quote property values if already quoted.

[Hans Leidekker]

From: Hans Leidekker <hans(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57024
---
 programs/msiexec/msiexec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/msiexec/msiexec.c b/programs/msiexec/msiexec.c
index d625b7a9b51..065730c7ff1 100644
--- a/programs/msiexec/msiexec.c
+++ b/programs/msiexec/msiexec.c
@@ -166,7 +166,7 @@ static LPWSTR build_properties(struct string_list *property_list)
 
 		/* check if the value contains spaces and maybe quote it */
 		value++;
-		needs_quote = wcschr(value,' ') ? 1 : 0;
+		needs_quote = *value != '"' && wcschr(value, ' ');
 		if(needs_quote)
 			*p++ = '"';
 		len = lstrlenW(value);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6434

[PATCH 1/1] msiexec: Don't quote property values if already quoted.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=148166

Your paranoid android.


=== debian11b (64 bit WoW report) ===

ddraw:
ddraw4.c:3969: Test failed: Expected message 0x5, but didn't receive it.