Re: [PATCH v2 0/2] MR8671: cryptowinrt: Stub ICryptographicBufferStatics::EncodeToBase64String().
30 Jul
2025
30 Jul
'25
2:50 p.m.
On Wed Jul 30 19:50:02 2025 +0000, Jinoh Kang wrote:
Surs, the game passes an empty string, but what about other games yet to be tested? Previously, the function reliably returned `E_NOTIMPL`, so that apps recognized the failure. Now this patch is returning empty string for *all* inputs. This might fix one game (that only passes empty input), but breaks everything else that passes non-empty input since the function lies that it did the job with an empty output. If a patch fixes a game and breaks 100 others, then it's not a good patch. Test added.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8671#note_111558
137
Age (days ago)
137
Last active (days ago)
0 comments
1 participants
participants (1)
-
Mohamad Al-Jaf (@maljaf)