[PATCH v19 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v19: win32u: Use the desktop shared data for NtUserSetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. include: Add ReadNoFence64 inline helpers. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
From: Rémi Bernon <rbernon(a)codeweavers.com> --- server/directory.c | 3 +++ server/file.h | 2 ++ server/mapping.c | 30 ++++++++++++++++++++++++++++++ server/protocol.def | 21 +++++++++++++++++++++ 4 files changed, 56 insertions(+) diff --git a/server/directory.c b/server/directory.c index 23d7eb0a2b7..20a0d1d49e8 100644 --- a/server/directory.c +++ b/server/directory.c @@ -439,8 +439,10 @@ void init_directories( struct fd *intl_fd ) /* mappings */ static const WCHAR intlW[] = {'N','l','s','S','e','c','t','i','o','n','L','A','N','G','_','I','N','T','L'}; static const WCHAR user_dataW[] = {'_','_','w','i','n','e','_','u','s','e','r','_','s','h','a','r','e','d','_','d','a','t','a'}; + static const WCHAR sessionW[] = {'_','_','w','i','n','e','_','s','e','s','s','i','o','n'}; static const struct unicode_str intl_str = {intlW, sizeof(intlW)}; static const struct unicode_str user_data_str = {user_dataW, sizeof(user_dataW)}; + static const struct unicode_str session_str = {sessionW, sizeof(sessionW)}; struct directory *dir_driver, *dir_device, *dir_global, *dir_kernel, *dir_nls; struct object *named_pipe_device, *mailslot_device, *null_device; @@ -489,6 +491,7 @@ void init_directories( struct fd *intl_fd ) /* mappings */ release_object( create_fd_mapping( &dir_nls->obj, &intl_str, intl_fd, OBJ_PERMANENT, NULL )); release_object( create_user_data_mapping( &dir_kernel->obj, &user_data_str, OBJ_PERMANENT, NULL )); + release_object( create_session_mapping( &dir_kernel->obj, &session_str, OBJ_PERMANENT, NULL )); release_object( intl_fd ); release_object( named_pipe_device ); diff --git a/server/file.h b/server/file.h index 7f2d1637863..079f065b263 100644 --- a/server/file.h +++ b/server/file.h @@ -188,6 +188,8 @@ extern struct mapping *create_fd_mapping( struct object *root, const struct unic unsigned int attr, const struct security_descriptor *sd ); extern struct object *create_user_data_mapping( struct object *root, const struct unicode_str *name, unsigned int attr, const struct security_descriptor *sd ); +extern struct object *create_session_mapping( struct object *root, const struct unicode_str *name, + unsigned int attr, const struct security_descriptor *sd ); /* device functions */ diff --git a/server/mapping.c b/server/mapping.c index 6b0de1b8b94..3a0c578ea4f 100644 --- a/server/mapping.c +++ b/server/mapping.c @@ -225,6 +225,15 @@ static const mem_size_t granularity_mask = 0xffff; static struct addr_range ranges32; static struct addr_range ranges64; +struct session +{ + const session_shm_t *shared; + unsigned int object_count; + unsigned int object_capacity; +}; +static struct mapping *session_mapping; +static struct session session; + #define ROUND_SIZE(size) (((size) + page_mask) & ~page_mask) void init_memory(void) @@ -1256,6 +1265,27 @@ int get_page_size(void) return page_mask + 1; } +struct object *create_session_mapping( struct object *root, const struct unicode_str *name, + unsigned int attr, const struct security_descriptor *sd ) +{ + static const unsigned int access = FILE_READ_DATA | FILE_WRITE_DATA; + struct mapping *mapping; + void *tmp; + + if (!(mapping = create_mapping( root, name, attr, 0x10000, SEC_COMMIT, 0, access, sd ))) return NULL; + if ((tmp = mmap( NULL, mapping->size, PROT_READ | PROT_WRITE, MAP_SHARED, get_unix_fd( mapping->fd ), 0 )) == MAP_FAILED) + { + release_object( &mapping->obj ); + return NULL; + } + + session_mapping = mapping; + session.object_capacity = (mapping->size - offsetof(session_shm_t, objects[0])) / sizeof(session_obj_t); + session.shared = tmp; + + return &mapping->obj; +} + struct object *create_user_data_mapping( struct object *root, const struct unicode_str *name, unsigned int attr, const struct security_descriptor *sd ) { diff --git a/server/protocol.def b/server/protocol.def index 8b51618ebe0..0f8fdea441e 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -879,6 +879,27 @@ typedef struct lparam_t info; } cursor_pos_t; +/****************************************************************/ +/* shared session mapping structures */ + +typedef volatile struct +{ + int placeholder; +} object_shm_t; + +typedef volatile union +{ + object_shm_t obj; +} session_obj_t; + +typedef volatile struct +{ + object_shm_t obj; + session_obj_t objects[]; +} session_shm_t; + +C_ASSERT(sizeof(session_shm_t) == offsetof(session_shm_t, objects[0])); + /****************************************************************/ /* Request declarations */ -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
From: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/win32u/winstation.c | 86 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 85 insertions(+), 1 deletion(-) diff --git a/dlls/win32u/winstation.c b/dlls/win32u/winstation.c index b187b246941..7537ce944d5 100644 --- a/dlls/win32u/winstation.c +++ b/dlls/win32u/winstation.c @@ -22,9 +22,12 @@ #pragma makedep unix #endif +#include <stdarg.h> +#include <stddef.h> +#include <pthread.h> + #include "ntstatus.h" #define WIN32_NO_STATUS -#include <stdarg.h> #include "windef.h" #include "winbase.h" #include "ntuser.h" @@ -40,6 +43,85 @@ WINE_DECLARE_DEBUG_CHANNEL(win); #define DESKTOP_ALL_ACCESS 0x01ff +static pthread_mutex_t session_lock = PTHREAD_MUTEX_INITIALIZER; +static struct shared_session *shared_session; + +struct shared_session +{ + LONG ref; + const session_shm_t *shared; +}; + +static struct shared_session *shared_session_acquire( struct shared_session *session ) +{ + InterlockedIncrement( &session->ref ); + return session; +} + +static void shared_session_release( struct shared_session *session ) +{ + if (!InterlockedDecrement( &session->ref )) + { + NtUnmapViewOfSection( GetCurrentProcess(), (void *)session->shared ); + free( session ); + } +} + +static struct shared_session *get_shared_session( BOOL force ) +{ + struct shared_session *session; + + pthread_mutex_lock( &session_lock ); + + if (!shared_session) force = TRUE; + if (force && (session = calloc( 1, sizeof(*session) ))) + { + static const WCHAR nameW[] = + { + '\\','K','e','r','n','e','l','O','b','j','e','c','t','s','\\', + '_','_','w','i','n','e','_','s','e','s','s','i','o','n',0 + }; + UNICODE_STRING name = RTL_CONSTANT_STRING( nameW ); + OBJECT_ATTRIBUTES attr; + unsigned int status; + HANDLE handle; + + session->ref = 1; + + InitializeObjectAttributes( &attr, &name, 0, NULL, NULL ); + if (!(status = NtOpenSection( &handle, SECTION_MAP_READ | SECTION_QUERY, &attr ))) + { + SECTION_BASIC_INFORMATION info; + + if (!(status = NtQuerySection( handle, SectionBasicInformation, &info, sizeof(info), NULL ))) + { + SIZE_T size = info.Size.QuadPart; + status = NtMapViewOfSection( handle, GetCurrentProcess(), (void **)&session->shared, + 0, 0, NULL, &size, ViewUnmap, 0, PAGE_READONLY ); + } + + NtClose( handle ); + } + + if (status) + { + ERR( "Failed to map session mapping, status %#x\n", status ); + free( session ); + } + else + { + if (shared_session) shared_session_release( shared_session ); + shared_session = session; + } + } + + session = shared_session_acquire( shared_session ); + + pthread_mutex_unlock( &session_lock ); + + return session; +} + BOOL is_virtual_desktop(void) { HANDLE desktop = NtUserGetThreadDesktop( GetCurrentThreadId() ); @@ -622,6 +704,8 @@ void winstation_init(void) static const WCHAR winsta0[] = {'W','i','n','S','t','a','0',0}; + shared_session = get_shared_session( FALSE ); + if (params->Desktop.Length) { buffer = malloc( params->Desktop.Length + sizeof(WCHAR) ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
From: Rémi Bernon <rbernon(a)codeweavers.com> --- server/file.h | 19 ++++++++ server/mapping.c | 109 ++++++++++++++++++++++++++++++++++++++++++++ server/protocol.def | 11 ++++- server/user.h | 1 + server/winstation.c | 18 ++++++++ 5 files changed, 157 insertions(+), 1 deletion(-) diff --git a/server/file.h b/server/file.h index 079f065b263..51fc6eb1858 100644 --- a/server/file.h +++ b/server/file.h @@ -191,6 +191,25 @@ extern struct object *create_user_data_mapping( struct object *root, const struc extern struct object *create_session_mapping( struct object *root, const struct unicode_str *name, unsigned int attr, const struct security_descriptor *sd ); +extern int alloc_shared_object(void); +extern void free_shared_object( int index ); +extern const desktop_shm_t *get_shared_desktop( int index ); + +#define SHARED_WRITE_BEGIN( object, type ) \ + do { \ + const type *__shared = (object); \ + type *shared = (type *)__shared; \ + LONG64 __seq = shared->obj.seq + 1, __end = __seq + 1; \ + assert( (__seq & 1) != 0 ); \ + __WINE_ATOMIC_STORE_RELEASE( &shared->obj.seq, &__seq ); \ + do + +#define SHARED_WRITE_END \ + while(0); \ + assert( __seq == shared->obj.seq ); \ + __WINE_ATOMIC_STORE_RELEASE( &shared->obj.seq, &__end ); \ + } while(0) + /* device functions */ extern struct object *create_named_pipe_device( struct object *root, const struct unicode_str *name, diff --git a/server/mapping.c b/server/mapping.c index 3a0c578ea4f..4a1d5a0c46e 100644 --- a/server/mapping.c +++ b/server/mapping.c @@ -1286,6 +1286,115 @@ struct object *create_session_mapping( struct object *root, const struct unicode return &mapping->obj; } +static int grow_session_mapping(void) +{ + struct session new_session; + unsigned int capacity; + mem_size_t size; + int unix_fd, i; + struct fd *fd; + + capacity = session.object_capacity * 3 / 2; + size = offsetof(session_shm_t, objects[capacity]); + size = (size + page_mask) & ~((mem_size_t)page_mask); + + if ((unix_fd = create_temp_file( size )) == -1) return -1; + if (!(fd = create_anonymous_fd( &mapping_fd_ops, unix_fd, &session_mapping->obj, FILE_SYNCHRONOUS_IO_NONALERT ))) + { + close( unix_fd ); + return -1; + } + if ((new_session.shared = mmap( NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, unix_fd, 0 )) == MAP_FAILED) + { + release_object( fd ); + return -1; + } + allow_fd_caching( fd ); + + SHARED_WRITE_BEGIN( new_session.shared, session_shm_t ) + { + const session_shm_t *old_shared = session.shared; + + /* copy the valid objects, mark the invalid ones as fully destroyed. No need + * to write-lock the objects as nothing can be using the new session yet. */ + for (i = 0; i < session.object_count; i++) + { + const object_shm_t *old_object = &old_shared->objects[i].obj; + object_shm_t *object = &shared->objects[i].obj; + + if (!old_object->invalid) *object = *old_object; + else object->destroyed = 1; + } + + new_session.object_count = session.object_count; + } + SHARED_WRITE_END; + + SHARED_WRITE_BEGIN( session.shared, session_shm_t ) + { + shared->obj.invalid = 1; + } + SHARED_WRITE_END; + + for (i = 0; i < session.object_count; i++) + { + const session_obj_t *object = &session.shared->objects[i]; + SHARED_WRITE_BEGIN( object, session_obj_t ) + { + shared->obj.invalid = 1; + } + SHARED_WRITE_END; + } + + munmap( (void *)session.shared, session_mapping->size ); + release_object( session_mapping->fd ); + session_mapping->size = size; + session_mapping->fd = fd; + session = new_session; + + return 0; +} + +int alloc_shared_object(void) +{ + int i; + + for (i = 0; i < session.object_count; i++) + { + const session_obj_t *object = &session.shared->objects[i]; + if (object->obj.destroyed) + { + SHARED_WRITE_BEGIN( object, session_obj_t ) + { + shared->obj.destroyed = 0; + } + SHARED_WRITE_END; + return i; + } + } + + if (session.object_count == session.object_capacity && grow_session_mapping()) return -1; + return session.object_count++; +} + +void free_shared_object( int index ) +{ + const session_obj_t *object = &session.shared->objects[index]; + + if (index < 0) return; + SHARED_WRITE_BEGIN( object, session_obj_t ) + { + shared->obj.invalid = 1; + } + SHARED_WRITE_END; +} + +const desktop_shm_t *get_shared_desktop( int index ) +{ + if (index < 0) return NULL; + return &session.shared->objects[index].desktop; +} + struct object *create_user_data_mapping( struct object *root, const struct unicode_str *name, unsigned int attr, const struct security_descriptor *sd ) { diff --git a/server/protocol.def b/server/protocol.def index 0f8fdea441e..00daa50f894 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -884,12 +884,20 @@ typedef struct typedef volatile struct { - int placeholder; + LONG64 seq; /* sequence number - server updating if (seq & 1) != 0 */ + unsigned int invalid; /* object has been invalidated, call wineserver */ + unsigned int destroyed; /* object has been destroyed, can be reused */ } object_shm_t; +typedef volatile struct +{ + object_shm_t obj; +} desktop_shm_t; + typedef volatile union { object_shm_t obj; + desktop_shm_t desktop; } session_obj_t; typedef volatile struct @@ -2801,6 +2809,7 @@ enum coords_relative thread_id_t tid; /* thread id */ @REPLY obj_handle_t handle; /* handle to the desktop */ + int session_index; /* index of desktop object in session shared memory */ @END diff --git a/server/user.h b/server/user.h index 8fa55e09b0f..32f648b4dc2 100644 --- a/server/user.h +++ b/server/user.h @@ -76,6 +76,7 @@ struct desktop unsigned int users; /* processes and threads using this desktop */ struct global_cursor cursor; /* global cursor information */ unsigned char keystate[256]; /* asynchronous key state */ + int session_index; /* desktop index in session shared memory */ }; /* user handles functions */ diff --git a/server/winstation.c b/server/winstation.c index 5903497d61e..0b6a118ef25 100644 --- a/server/winstation.c +++ b/server/winstation.c @@ -240,6 +240,13 @@ static struct desktop *create_desktop( const struct unicode_str *name, unsigned memset( desktop->keystate, 0, sizeof(desktop->keystate) ); list_add_tail( &winstation->desktops, &desktop->entry ); list_init( &desktop->hotkeys ); + desktop->session_index = -1; + + if ((desktop->session_index = alloc_shared_object()) == -1) + { + release_object( desktop ); + return NULL; + } } else { @@ -298,6 +305,7 @@ static void desktop_destroy( struct object *obj ) if (desktop->close_timeout) remove_timeout_user( desktop->close_timeout ); list_remove( &desktop->entry ); release_object( desktop->winstation ); + free_shared_object( desktop->session_index ); } /* retrieve the thread desktop, checking the handle access rights */ @@ -601,10 +609,20 @@ DECL_HANDLER(close_desktop) /* get the thread current desktop */ DECL_HANDLER(get_thread_desktop) { + struct desktop *desktop; struct thread *thread; if (!(thread = get_thread_from_id( req->tid ))) return; reply->handle = thread->desktop; + + if (!(desktop = get_thread_desktop( thread, 0 ))) + reply->session_index = -1; + else + { + reply->session_index = desktop->session_index; + release_object( desktop ); + } + release_object( thread ); } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
From: Rémi Bernon <rbernon(a)codeweavers.com> --- include/winnt.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/winnt.h b/include/winnt.h index 0e0d1cb5170..24df62404c5 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -6990,11 +6990,14 @@ static FORCEINLINE void MemoryBarrier(void) */ #if _MSC_VER >= 1700 #pragma intrinsic(__iso_volatile_load32) +#pragma intrinsic(__iso_volatile_load64) #pragma intrinsic(__iso_volatile_store32) #define __WINE_LOAD32_NO_FENCE(src) (__iso_volatile_load32(src)) +#define __WINE_LOAD64_NO_FENCE(src) (__iso_volatile_load64(src)) #define __WINE_STORE32_NO_FENCE(dest, value) (__iso_volatile_store32(dest, value)) #else /* _MSC_VER >= 1700 */ #define __WINE_LOAD32_NO_FENCE(src) (*(src)) +#define __WINE_LOAD64_NO_FENCE(src) (*(src)) #define __WINE_STORE32_NO_FENCE(dest, value) ((void)(*(dest) = (value))) #endif /* _MSC_VER >= 1700 */ @@ -7028,6 +7031,12 @@ static FORCEINLINE LONG ReadNoFence( LONG const volatile *src ) return value; } +static FORCEINLINE LONG64 ReadNoFence64( LONG64 const volatile *src ) +{ + LONG64 value = __WINE_LOAD64_NO_FENCE( (__int64 const volatile *)src ); + return value; +} + static FORCEINLINE void WriteRelease( LONG volatile *dest, LONG value ) { __wine_memory_barrier_acq_rel(); @@ -7214,6 +7223,13 @@ static FORCEINLINE LONG ReadNoFence( LONG const volatile *src ) return value; } +static FORCEINLINE LONG64 ReadNoFence64( LONG64 const volatile *src ) +{ + LONG64 value; + __WINE_ATOMIC_LOAD_RELAXED( src, &value ); + return value; +} + static FORCEINLINE void WriteRelease( LONG volatile *dest, LONG value ) { __WINE_ATOMIC_STORE_RELEASE( dest, &value ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
From: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/win32u/ntuser_private.h | 1 + dlls/win32u/sysparams.c | 1 + dlls/win32u/win32u_private.h | 36 +++++++++++++++++++ dlls/win32u/winstation.c | 70 ++++++++++++++++++++++++++++++++++++ 4 files changed, 108 insertions(+) diff --git a/dlls/win32u/ntuser_private.h b/dlls/win32u/ntuser_private.h index 3b6cab5bdc9..25448f62f7e 100644 --- a/dlls/win32u/ntuser_private.h +++ b/dlls/win32u/ntuser_private.h @@ -127,6 +127,7 @@ struct user_thread_info UINT spy_indent; /* Current spy indent */ BOOL clipping_cursor; /* thread is currently clipping */ DWORD clipping_reset; /* time when clipping was last reset */ + struct shared_desktop *shared_desktop; /* thread desktop shared session object */ }; C_ASSERT( sizeof(struct user_thread_info) <= sizeof(((TEB *)0)->Win32ClientInfo) ); diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index 673082056b1..06042816e2e 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -6204,6 +6204,7 @@ static void thread_detach(void) destroy_thread_windows(); cleanup_imm_thread(); NtClose( thread_info->server_queue ); + if (thread_info->shared_desktop) shared_desktop_release( thread_info->shared_desktop ); exiting_thread_id = 0; } diff --git a/dlls/win32u/win32u_private.h b/dlls/win32u/win32u_private.h index d5f010a8249..990176d389c 100644 --- a/dlls/win32u/win32u_private.h +++ b/dlls/win32u/win32u_private.h @@ -194,6 +194,19 @@ extern void user_unlock(void); extern void user_check_not_lock(void); /* winstation.c */ + +struct shared_session; + +struct shared_desktop +{ + LONG ref; + const desktop_shm_t *shared; + struct shared_session *session; +}; + +extern void shared_desktop_release( struct shared_desktop *desktop ); +extern struct shared_desktop *get_shared_desktop( BOOL force ); + extern BOOL is_virtual_desktop(void); /* window.c */ @@ -362,4 +375,27 @@ static inline BOOL intersect_rect( RECT *dst, const RECT *src1, const RECT *src2 return !IsRectEmpty( dst ); } +#if defined(__i386__) || defined(__x86_64__) +/* this prevents compilers from incorrectly reordering non-volatile reads (e.g., memcpy) from shared memory */ +#define __SHARED_READ_FENCE do { __asm__ __volatile__( "" ::: "memory" ); } while (0) +#else +#define __SHARED_READ_FENCE __atomic_thread_fence( __ATOMIC_ACQUIRE ) +#endif + +#define SHARED_READ_BEGIN( ptr, type ) \ + do { \ + const type *shared = (ptr); \ + LONG64 __seq; \ + do { \ + while ((__seq = ReadNoFence64( &shared->obj.seq )) & 1) \ + YieldProcessor(); \ + __SHARED_READ_FENCE; \ + do + +#define SHARED_READ_END \ + while (0); \ + __SHARED_READ_FENCE; \ + } while (ReadNoFence64( &shared->obj.seq ) != __seq); \ + } while(0) + #endif /* __WINE_WIN32U_PRIVATE */ diff --git a/dlls/win32u/winstation.c b/dlls/win32u/winstation.c index 7537ce944d5..9cc35e994b5 100644 --- a/dlls/win32u/winstation.c +++ b/dlls/win32u/winstation.c @@ -122,6 +122,73 @@ static struct shared_session *get_shared_session( BOOL force ) return session; } +static struct shared_desktop *shared_desktop_acquire( struct shared_desktop *desktop ) +{ + InterlockedIncrement( &desktop->ref ); + return desktop; +} + +void shared_desktop_release( struct shared_desktop *desktop ) +{ + if (!InterlockedDecrement( &desktop->ref )) + { + shared_session_release( desktop->session ); + free( desktop ); + } +} + +struct shared_desktop *get_shared_desktop( BOOL force ) +{ + struct user_thread_info *thread_info = get_user_thread_info(); + struct shared_desktop *desktop; + + if (!thread_info->shared_desktop) force = TRUE; + if (force && (desktop = calloc( 1, sizeof(*desktop) ))) + { + const desktop_shm_t *ptr = NULL; + struct shared_session *session; + BOOL invalid = FALSE; + unsigned int idx; + + while ((session = get_shared_session( invalid ))) + { + SERVER_START_REQ( get_thread_desktop ) + { + req->tid = GetCurrentThreadId(); + if (wine_server_call_err( req )) idx = -1; + else idx = reply->session_index; + } + SERVER_END_REQ; + if (idx == -1) break; + + SHARED_READ_BEGIN( session->shared, session_shm_t ) + { + if ((invalid = shared->obj.invalid)) ptr = NULL; + else ptr = &shared->objects[idx].desktop; + } + SHARED_READ_END; + + if (!invalid) break; + shared_session_release( session ); + } + + if (idx == -1) + { + free( desktop ); + return NULL; + } + + desktop->ref = 1; + if (!(desktop->shared = ptr)) ERR( "Failed to map desktop shared memory\n" ); + desktop->session = session; + + if (thread_info->shared_desktop) shared_desktop_release( thread_info->shared_desktop ); + thread_info->shared_desktop = desktop; + } + + return shared_desktop_acquire( thread_info->shared_desktop ); +} + BOOL is_virtual_desktop(void) { HANDLE desktop = NtUserGetThreadDesktop( GetCurrentThreadId() ); @@ -346,6 +413,9 @@ BOOL WINAPI NtUserSetThreadDesktop( HDESK handle ) thread_info->client_info.top_window = 0; thread_info->client_info.msg_window = 0; if (key_state_info) key_state_info->time = 0; + if (thread_info->shared_desktop) shared_desktop_release( thread_info->shared_desktop ); + thread_info->shared_desktop = NULL; + get_shared_desktop( FALSE ); if (was_virtual_desktop != is_virtual_desktop()) update_display_cache( TRUE ); } return ret; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
From: Rémi Bernon <rbernon(a)codeweavers.com> Based on a patch by Huw Davies <huw(a)codeweavers.com>. --- server/protocol.def | 7 +++++ server/queue.c | 73 ++++++++++++++++++++++++++++----------------- server/user.h | 2 -- 3 files changed, 52 insertions(+), 30 deletions(-) diff --git a/server/protocol.def b/server/protocol.def index 00daa50f894..40910ae2242 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -882,6 +882,12 @@ typedef struct /****************************************************************/ /* shared session mapping structures */ +struct shared_cursor +{ + int x; /* cursor position */ + int y; +}; + typedef volatile struct { LONG64 seq; /* sequence number - server updating if (seq & 1) != 0 */ @@ -892,6 +898,7 @@ typedef volatile struct typedef volatile struct { object_shm_t obj; + struct shared_cursor cursor; /* global cursor information */ } desktop_shm_t; typedef volatile union diff --git a/server/queue.c b/server/queue.c index 6f38227aa84..58396dfa912 100644 --- a/server/queue.c +++ b/server/queue.c @@ -416,6 +416,7 @@ static void queue_cursor_message( struct desktop *desktop, user_handle_t win, un lparam_t wparam, lparam_t lparam ) { static const struct hw_msg_source source = { IMDT_UNAVAILABLE, IMO_SYSTEM }; + const desktop_shm_t *desktop_shm = get_shared_desktop( desktop->session_index ); struct thread_input *input; struct message *msg; @@ -424,8 +425,8 @@ static void queue_cursor_message( struct desktop *desktop, user_handle_t win, un msg->msg = message; msg->wparam = wparam; msg->lparam = lparam; - msg->x = desktop->cursor.x; - msg->y = desktop->cursor.y; + msg->x = desktop_shm->cursor.x; + msg->y = desktop_shm->cursor.y; if (!(msg->win = win) && (input = desktop->foreground_input)) msg->win = input->active; queue_hardware_message( desktop, msg, 1 ); } @@ -463,13 +464,20 @@ static int update_desktop_cursor_window( struct desktop *desktop, user_handle_t static int update_desktop_cursor_pos( struct desktop *desktop, user_handle_t win, int x, int y ) { + const desktop_shm_t *desktop_shm = get_shared_desktop( desktop->session_index ); int updated; x = max( min( x, desktop->cursor.clip.right - 1 ), desktop->cursor.clip.left ); y = max( min( y, desktop->cursor.clip.bottom - 1 ), desktop->cursor.clip.top ); - updated = (desktop->cursor.x != x || desktop->cursor.y != y); - desktop->cursor.x = x; - desktop->cursor.y = y; + + SHARED_WRITE_BEGIN( desktop_shm, desktop_shm_t ) + { + updated = shared->cursor.x != x || shared->cursor.y != y; + shared->cursor.x = x; + shared->cursor.y = y; + } + SHARED_WRITE_END; + desktop->cursor.last_change = get_tick_count(); if (!win || !is_window_visible( win ) || is_window_transparent( win )) @@ -515,15 +523,17 @@ static void set_cursor_pos( struct desktop *desktop, int x, int y ) static void get_message_defaults( struct msg_queue *queue, int *x, int *y, unsigned int *time ) { struct desktop *desktop = queue->input->desktop; + const desktop_shm_t *desktop_shm = get_shared_desktop( desktop->session_index ); - *x = desktop->cursor.x; - *y = desktop->cursor.y; + *x = desktop_shm->cursor.x; + *y = desktop_shm->cursor.y; *time = get_tick_count(); } /* set the cursor clip rectangle */ void set_clip_rectangle( struct desktop *desktop, const rectangle_t *rect, unsigned int flags, int reset ) { + const desktop_shm_t *desktop_shm = get_shared_desktop( desktop->session_index ); rectangle_t top_rect; int x, y; @@ -541,9 +551,9 @@ void set_clip_rectangle( struct desktop *desktop, const rectangle_t *rect, unsig else desktop->cursor.clip = top_rect; /* warp the mouse to be inside the clip rect */ - x = max( min( desktop->cursor.x, desktop->cursor.clip.right - 1 ), desktop->cursor.clip.left ); - y = max( min( desktop->cursor.y, desktop->cursor.clip.bottom - 1 ), desktop->cursor.clip.top ); - if (x != desktop->cursor.x || y != desktop->cursor.y) set_cursor_pos( desktop, x, y ); + x = max( min( desktop_shm->cursor.x, desktop->cursor.clip.right - 1 ), desktop->cursor.clip.left ); + y = max( min( desktop_shm->cursor.y, desktop->cursor.clip.bottom - 1 ), desktop->cursor.clip.top ); + if (x != desktop_shm->cursor.x || y != desktop_shm->cursor.y) set_cursor_pos( desktop, x, y ); /* request clip cursor rectangle reset to the desktop thread */ if (reset) post_desktop_message( desktop, WM_WINE_CLIPCURSOR, flags, FALSE ); @@ -1664,6 +1674,7 @@ static void prepend_cursor_history( int x, int y, unsigned int time, lparam_t in /* queue a hardware message into a given thread input */ static void queue_hardware_message( struct desktop *desktop, struct message *msg, int always_queue ) { + const desktop_shm_t *desktop_shm = get_shared_desktop( desktop->session_index ); user_handle_t win; struct thread *thread; struct thread_input *input; @@ -1696,8 +1707,8 @@ static void queue_hardware_message( struct desktop *desktop, struct message *msg if (desktop->keystate[VK_XBUTTON2] & 0x80) msg->wparam |= MK_XBUTTON2; break; } - msg->x = desktop->cursor.x; - msg->y = desktop->cursor.y; + msg->x = desktop_shm->cursor.x; + msg->y = desktop_shm->cursor.y; if (msg->win && (thread = get_window_thread( msg->win ))) { @@ -1991,6 +2002,7 @@ done: static int queue_mouse_message( struct desktop *desktop, user_handle_t win, const hw_input_t *input, unsigned int origin, struct msg_queue *sender ) { + const desktop_shm_t *desktop_shm = get_shared_desktop( desktop->session_index ); const struct rawinput_device *device; struct hardware_msg_data *msg_data; struct rawinput_message raw_msg; @@ -2029,19 +2041,19 @@ static int queue_mouse_message( struct desktop *desktop, user_handle_t win, cons x = input->mouse.x; y = input->mouse.y; if (flags & ~(MOUSEEVENTF_MOVE | MOUSEEVENTF_ABSOLUTE) && - x == desktop->cursor.x && y == desktop->cursor.y) + x == desktop_shm->cursor.x && y == desktop_shm->cursor.y) flags &= ~MOUSEEVENTF_MOVE; } else { - x = desktop->cursor.x + input->mouse.x; - y = desktop->cursor.y + input->mouse.y; + x = desktop_shm->cursor.x + input->mouse.x; + y = desktop_shm->cursor.y + input->mouse.y; } } else { - x = desktop->cursor.x; - y = desktop->cursor.y; + x = desktop_shm->cursor.x; + y = desktop_shm->cursor.y; } if ((foreground = get_foreground_thread( desktop, win ))) @@ -2053,7 +2065,7 @@ static int queue_mouse_message( struct desktop *desktop, user_handle_t win, cons raw_msg.time = time; raw_msg.message = WM_INPUT; raw_msg.flags = flags; - rawmouse_init( &raw_msg.rawinput, &raw_msg.data.mouse, x - desktop->cursor.x, y - desktop->cursor.y, + rawmouse_init( &raw_msg.rawinput, &raw_msg.data.mouse, x - desktop_shm->cursor.x, y - desktop_shm->cursor.y, raw_msg.flags, input->mouse.data, input->mouse.info ); enum_processes( queue_rawinput_message, &raw_msg ); @@ -2233,6 +2245,7 @@ static int queue_keyboard_message( struct desktop *desktop, user_handle_t win, c static void queue_custom_hardware_message( struct desktop *desktop, user_handle_t win, unsigned int origin, const hw_input_t *input ) { + const desktop_shm_t *desktop_shm = get_shared_desktop( desktop->session_index ); struct hw_msg_source source = { IMDT_UNAVAILABLE, origin }; struct rawinput_message raw_msg; struct message *msg; @@ -2263,8 +2276,8 @@ static void queue_custom_hardware_message( struct desktop *desktop, user_handle_ msg->msg = input->hw.msg; msg->wparam = 0; msg->lparam = input->hw.lparam; - msg->x = desktop->cursor.x; - msg->y = desktop->cursor.y; + msg->x = desktop_shm->cursor.x; + msg->y = desktop_shm->cursor.y; queue_hardware_message( desktop, msg, 1 ); } @@ -2771,8 +2784,10 @@ DECL_HANDLER(send_hardware_message) struct desktop *desktop; unsigned int origin = (req->flags & SEND_HWMSG_INJECTED ? IMO_INJECTED : IMO_HARDWARE); struct msg_queue *sender = get_current_queue(); + const desktop_shm_t *desktop_shm; if (!(desktop = get_thread_desktop( current, 0 ))) return; + desktop_shm = get_shared_desktop( desktop->session_index ); if (req->win) { @@ -2785,8 +2800,8 @@ DECL_HANDLER(send_hardware_message) } } - reply->prev_x = desktop->cursor.x; - reply->prev_y = desktop->cursor.y; + reply->prev_x = desktop_shm->cursor.x; + reply->prev_y = desktop_shm->cursor.y; switch (req->input.type) { @@ -2804,8 +2819,8 @@ DECL_HANDLER(send_hardware_message) } if (thread) release_object( thread ); - reply->new_x = desktop->cursor.x; - reply->new_y = desktop->cursor.y; + reply->new_x = desktop_shm->cursor.x; + reply->new_y = desktop_shm->cursor.y; release_object( desktop ); } @@ -3490,15 +3505,17 @@ DECL_HANDLER(set_cursor) struct msg_queue *queue = get_current_queue(); struct thread_input *input; struct desktop *desktop; + const desktop_shm_t *desktop_shm; if (!queue) return; input = queue->input; desktop = input->desktop; + desktop_shm = get_shared_desktop( desktop->session_index ); reply->prev_handle = input->cursor; reply->prev_count = input->cursor_count; - reply->prev_x = desktop->cursor.x; - reply->prev_y = desktop->cursor.y; + reply->prev_x = desktop_shm->cursor.x; + reply->prev_y = desktop_shm->cursor.y; if (req->flags & SET_CURSOR_HANDLE) { @@ -3521,8 +3538,8 @@ DECL_HANDLER(set_cursor) if (req->flags & (SET_CURSOR_HANDLE | SET_CURSOR_COUNT)) update_desktop_cursor_handle( desktop, input ); - reply->new_x = desktop->cursor.x; - reply->new_y = desktop->cursor.y; + reply->new_x = desktop_shm->cursor.x; + reply->new_y = desktop_shm->cursor.y; reply->new_clip = desktop->cursor.clip; reply->last_change = desktop->cursor.last_change; } diff --git a/server/user.h b/server/user.h index 32f648b4dc2..8ff3c3bfc33 100644 --- a/server/user.h +++ b/server/user.h @@ -54,8 +54,6 @@ struct winstation struct global_cursor { - int x; /* cursor position */ - int y; rectangle_t clip; /* cursor clip rectangle */ unsigned int last_change; /* time of last position change */ user_handle_t win; /* window that contains the cursor */ -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
From: Rémi Bernon <rbernon(a)codeweavers.com> Based on a patch by Huw Davies <huw(a)codeweavers.com>. --- server/protocol.def | 1 + server/queue.c | 17 +++++++++++------ server/user.h | 1 - 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/server/protocol.def b/server/protocol.def index 40910ae2242..83037152cc6 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -886,6 +886,7 @@ struct shared_cursor { int x; /* cursor position */ int y; + unsigned int last_change; /* time of last position change */ }; typedef volatile struct diff --git a/server/queue.c b/server/queue.c index 58396dfa912..f39c7e6cfcb 100644 --- a/server/queue.c +++ b/server/queue.c @@ -466,6 +466,7 @@ static int update_desktop_cursor_pos( struct desktop *desktop, user_handle_t win { const desktop_shm_t *desktop_shm = get_shared_desktop( desktop->session_index ); int updated; + unsigned int time = get_tick_count(); x = max( min( x, desktop->cursor.clip.right - 1 ), desktop->cursor.clip.left ); y = max( min( y, desktop->cursor.clip.bottom - 1 ), desktop->cursor.clip.top ); @@ -475,11 +476,10 @@ static int update_desktop_cursor_pos( struct desktop *desktop, user_handle_t win updated = shared->cursor.x != x || shared->cursor.y != y; shared->cursor.x = x; shared->cursor.y = y; + shared->cursor.last_change = time; } SHARED_WRITE_END; - desktop->cursor.last_change = get_tick_count(); - if (!win || !is_window_visible( win ) || is_window_transparent( win )) win = shallow_window_from_point( desktop, x, y ); if (update_desktop_cursor_window( desktop, win )) updated = 1; @@ -2008,7 +2008,7 @@ static int queue_mouse_message( struct desktop *desktop, user_handle_t win, cons struct rawinput_message raw_msg; struct message *msg; struct thread *foreground; - unsigned int i, time, flags; + unsigned int i, time = get_tick_count(), flags; struct hw_msg_source source = { IMDT_MOUSE, origin }; int wait = 0, x, y; @@ -2029,10 +2029,15 @@ static int queue_mouse_message( struct desktop *desktop, user_handle_t win, cons WM_MOUSEHWHEEL /* 0x1000 = MOUSEEVENTF_HWHEEL */ }; - desktop->cursor.last_change = get_tick_count(); + SHARED_WRITE_BEGIN( desktop_shm, desktop_shm_t ) + { + shared->cursor.last_change = time; + } + SHARED_WRITE_END; + flags = input->mouse.flags; time = input->mouse.time; - if (!time) time = desktop->cursor.last_change; + if (!time) time = desktop_shm->cursor.last_change; if (flags & MOUSEEVENTF_MOVE) { @@ -3541,7 +3546,7 @@ DECL_HANDLER(set_cursor) reply->new_x = desktop_shm->cursor.x; reply->new_y = desktop_shm->cursor.y; reply->new_clip = desktop->cursor.clip; - reply->last_change = desktop->cursor.last_change; + reply->last_change = desktop_shm->cursor.last_change; } /* Get the history of the 64 last cursor positions */ diff --git a/server/user.h b/server/user.h index 8ff3c3bfc33..6b93f9f4ca8 100644 --- a/server/user.h +++ b/server/user.h @@ -55,7 +55,6 @@ struct winstation struct global_cursor { rectangle_t clip; /* cursor clip rectangle */ - unsigned int last_change; /* time of last position change */ user_handle_t win; /* window that contains the cursor */ }; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
From: Rémi Bernon <rbernon(a)codeweavers.com> Based on a patch by Huw Davies <huw(a)codeweavers.com>. --- dlls/win32u/input.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/dlls/win32u/input.c b/dlls/win32u/input.c index ef8d564c264..b6e8037769e 100644 --- a/dlls/win32u/input.c +++ b/dlls/win32u/input.c @@ -749,22 +749,27 @@ BOOL WINAPI NtUserSetCursorPos( INT x, INT y ) */ BOOL get_cursor_pos( POINT *pt ) { - BOOL ret; - DWORD last_change; + BOOL invalid = FALSE, ret = FALSE; + struct shared_desktop *desktop; + DWORD last_change = 0; UINT dpi; if (!pt) return FALSE; - SERVER_START_REQ( set_cursor ) + while ((desktop = get_shared_desktop( invalid ))) { - if ((ret = !wine_server_call( req ))) + SHARED_READ_BEGIN( desktop->shared, desktop_shm_t ) { - pt->x = reply->new_x; - pt->y = reply->new_y; - last_change = reply->last_change; + if ((invalid = shared->obj.invalid)) break; + pt->x = shared->cursor.x; + pt->y = shared->cursor.y; + last_change = shared->cursor.last_change; + ret = TRUE; } + SHARED_READ_END; + shared_desktop_release( desktop ); + if (!invalid) break; } - SERVER_END_REQ; /* query new position from graphics driver if we haven't updated recently */ if (ret && NtGetTickCount() - last_change > 100) ret = user_driver->pGetCursorPos( pt ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3103
Updated with desktop shared memory allocated in a global session mapping. For simplicity all objects are placed in a session_object union, which is the only allocation granularity. The session mapping is reallocated as needed, copying valid objects and marking all objects in the old session as invalid. Clients would read the invalid flags, discard their stale session mapping and request the new one. I updated the https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories branch with this approach applied to the other object types. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_61975
Jinoh Kang (@iamahuman) commented about dlls/win32u/winstation.c:
+void shared_desktop_release( struct shared_desktop *desktop ) +{ + if (!InterlockedDecrement( &desktop->ref )) + { + shared_session_release( desktop->session ); + free( desktop ); + } +} + +struct shared_desktop *get_shared_desktop( BOOL force ) +{ + struct user_thread_info *thread_info = get_user_thread_info(); + struct shared_desktop *desktop; + + if (!thread_info->shared_desktop) force = TRUE; + if (force && (desktop = calloc( 1, sizeof(*desktop) ))) If `calloc` fails, we crash anyway at line 189 (since `thread_info->shared_desktop == NULL`). Checking for NULL here gives false illusion that we care, when we actually don't.
We should just move `desktop = calloc( 1, sizeof(*desktop) )` into the `if`-then body. Precedent: <https://gitlab.winehq.org/wine/wine/-/merge_requests/4152#note_52757> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_62036
Jinoh Kang (@iamahuman) commented about dlls/win32u/winstation.c:
+{ + if (!InterlockedDecrement( &session->ref )) + { + NtUnmapViewOfSection( GetCurrentProcess(), (void *)session->shared ); + free( session ); + } +} + +static struct shared_session *get_shared_session( BOOL force ) +{ + struct shared_session *session; + + pthread_mutex_lock( &session_lock ); + + if (!shared_session) force = TRUE; + if (force && (session = calloc( 1, sizeof(*session) ))) If `calloc` fails, we crash anyway at line 118 (since `thread_info->shared_desktop == NULL`). Checking for NULL here gives false illusion that we care, when we actually don't.
We should just move `session = calloc( 1, sizeof(*session) )` into the `if`-then body. Precedent: <https://gitlab.winehq.org/wine/wine/-/merge_requests/4152#note_52757> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_62037
Jinoh Kang (@iamahuman) commented about server/mapping.c:
+ shared->obj.destroyed = 0; + } + SHARED_WRITE_END; + return i; + } + } + + if (session.object_count == session.object_capacity && grow_session_mapping()) return -1; + return session.object_count++; +} + +void free_shared_object( int index ) +{ + const session_obj_t *object = &session.shared->objects[index]; + + if (index < 0) return; Undefined behavior due to out-of-bounds pointer generation.
```suggestion:-2+0 const session_obj_t *object; if (index < 0) return; object = &session.shared->objects[index]; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_62039
Jinoh Kang (@iamahuman) commented about dlls/win32u/winstation.c:
+ unsigned int status; + HANDLE handle; + + session->ref = 1; + + InitializeObjectAttributes( &attr, &name, 0, NULL, NULL ); + if (!(status = NtOpenSection( &handle, SECTION_MAP_READ | SECTION_QUERY, &attr ))) + { + SECTION_BASIC_INFORMATION info; + + if (!(status = NtQuerySection( handle, SectionBasicInformation, &info, sizeof(info), NULL ))) + { + SIZE_T size = info.Size.QuadPart; + status = NtMapViewOfSection( handle, GetCurrentProcess(), (void **)&session->shared, + 0, 0, NULL, &size, ViewUnmap, 0, PAGE_READONLY ); + } This will race (between NtQuerySection and NtMapViewOfSection) if the mapping grows in the meantime.
This should loop until `NtMapViewOfSection` no longer returns `STATUS_INVALID_PARAMETER`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_62040
Jinoh Kang (@iamahuman) commented about server/mapping.c:
+ SHARED_WRITE_END; + + for (i = 0; i < session.object_count; i++) + { + const session_obj_t *object = &session.shared->objects[i]; + SHARED_WRITE_BEGIN( object, session_obj_t ) + { + shared->obj.invalid = 1; + } + SHARED_WRITE_END; + } + + munmap( (void *)session.shared, session_mapping->size ); + release_object( session_mapping->fd ); + session_mapping->size = size; + session_mapping->fd = fd; Replacing the backing memory/fd of a mapping object is unprecedented and I'm afraid this might cause regressing due to existing assumptions on a mapping object.
Instead, I suggest that you remove `OBJ_PERMANENT` flag[^perma], unlink the existing mapping[^unlink], and call `create_mapping` to construct a new one. This will also solve the query size race condition automatically. [^perma]: This requires you to make `session_mapping` a reference: see the suggestion about `session_mapping = (struct mapping *)grab_object( &mapping->obj );`. [^unlink]: See `unlink_named_object`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_62041
Jinoh Kang (@iamahuman) commented about server/mapping.c:
+struct object *create_session_mapping( struct object *root, const struct unicode_str *name, + unsigned int attr, const struct security_descriptor *sd ) +{ + static const unsigned int access = FILE_READ_DATA | FILE_WRITE_DATA; + struct mapping *mapping; + void *tmp; + + if (!(mapping = create_mapping( root, name, attr, 0x10000, SEC_COMMIT, 0, access, sd ))) return NULL; + if ((tmp = mmap( NULL, mapping->size, PROT_READ | PROT_WRITE, MAP_SHARED, get_unix_fd( mapping->fd ), 0 )) == MAP_FAILED) + { + release_object( &mapping->obj ); + return NULL; + } + + session_mapping = mapping;
`session_mapping` should be treated as a reference. ```suggestion:-0+0 session_mapping = (struct mapping *)grab_object( &mapping->obj ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_62042
Jinoh Kang (@iamahuman) commented about server/mapping.c:
+ session_mapping = mapping; + session.object_capacity = (mapping->size - offsetof(session_shm_t, objects[0])) / sizeof(session_obj_t); + session.shared = tmp; + + return &mapping->obj; +} + +static int grow_session_mapping(void) +{ + struct session new_session; + unsigned int capacity; + mem_size_t size; + int unix_fd, i; + struct fd *fd; + + capacity = session.object_capacity * 3 / 2; To avoid unnecesary growth, I suggest that you keep track of number of allocated (`!invalid && !destroyed`) objects and use it to calculate capacity.
Otherwise, we end up unnecessarily extending size when e.g., 50% of the mapping is actually unused (invalid). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_62043
Jinoh Kang (@iamahuman) commented about server/mapping.c:
+ size = (size + page_mask) & ~((mem_size_t)page_mask); + + if ((unix_fd = create_temp_file( size )) == -1) return -1; + if (!(fd = create_anonymous_fd( &mapping_fd_ops, unix_fd, &session_mapping->obj, FILE_SYNCHRONOUS_IO_NONALERT ))) + { + close( unix_fd ); + return -1; + } + if ((new_session.shared = mmap( NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, unix_fd, 0 )) == MAP_FAILED) + { + release_object( fd ); + return -1; + } + allow_fd_caching( fd ); + + SHARED_WRITE_BEGIN( new_session.shared, session_shm_t ) No need to write-lock the new session as nothing can be using the new session yet.
Not using `SHARED_WRITE_BEGIN` for any potentially long-running code makes the shared memory users easier to reason about. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3103#note_62044
participants (2)
-
Jinoh Kang (＠iamahuman) -
Rémi Bernon