[PATCH 0/1] MR3470: webservices: Make alloc_float_text() static.

[Francois Gouget (＠fgouget)]

This was meant to be used by the writer at some point:  
https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.org/thre...

But that was almost 6 years ago and it is still not used anywhere else.
So I would argue for making it static to ensure it is removed in case
it goes unused instead of being used in more places.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3470

[PATCH 1/1] webservices: Make alloc_float_text() static.

[Francois Gouget]

From: Francois Gouget <fgouget(a)free.fr>

---
This was meant to be used by the writer at some point:
https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.org/thre...

But that was almost 6 years ago and it is still not used anywhere else.
So I would argue for making it static to ensure it is removed in case
it goes unused instead of being used in more places.
---
 dlls/webservices/reader.c              | 2 +-
 dlls/webservices/webservices_private.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c
index 41b2adc8724..0c8ddcea035 100644
--- a/dlls/webservices/reader.c
+++ b/dlls/webservices/reader.c
@@ -914,7 +914,7 @@ WS_XML_UINT64_TEXT *alloc_uint64_text( UINT64 value )
     return ret;
 }
 
-WS_XML_FLOAT_TEXT *alloc_float_text( float value )
+static WS_XML_FLOAT_TEXT *alloc_float_text( float value )
 {
     WS_XML_FLOAT_TEXT *ret;
 
diff --git a/dlls/webservices/webservices_private.h b/dlls/webservices/webservices_private.h
index b754b36d02c..806d79ba4f2 100644
--- a/dlls/webservices/webservices_private.h
+++ b/dlls/webservices/webservices_private.h
@@ -83,7 +83,6 @@ WS_XML_BOOL_TEXT *alloc_bool_text( BOOL );
 WS_XML_INT32_TEXT *alloc_int32_text( INT32 );
 WS_XML_INT64_TEXT *alloc_int64_text( INT64 );
 WS_XML_UINT64_TEXT *alloc_uint64_text( UINT64 );
-WS_XML_FLOAT_TEXT *alloc_float_text( float );
 WS_XML_DOUBLE_TEXT *alloc_double_text( double );
 WS_XML_GUID_TEXT *alloc_guid_text( const GUID * );
 WS_XML_UNIQUE_ID_TEXT *alloc_unique_id_text( const GUID * );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3470

[PATCH 0/1] MR3470: webservices: Make alloc_float_text() static. - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3470