[PATCH 0/1] MR4333: wininet: Use SecureZeroMemory() to clear magic fields.
Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4333
From: Eric Pouech <epouech(a)codeweavers.com> Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> --- dlls/wininet/urlcache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index bad6f34b510..8e43eaae9f3 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -3630,7 +3630,8 @@ BOOL WINAPI FindCloseUrlCache(HANDLE hEnumHandle) return FALSE; } - pEntryHandle->magic = 0; + /* Ensure compiler doesn't optimize out the assignment with 0. */ + SecureZeroMemory(&pEntryHandle->magic, sizeof(pEntryHandle->magic)); free(pEntryHandle->url_search_pattern); free(pEntryHandle); return TRUE; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4333
This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4333
participants (3)
-
Eric Pouech -
eric pouech (@epo) -
Jacek Caban (@jacek)