Re: [PATCH v5 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.

[Giovanni Mascellani (＠giomasce)]

On Thu Dec 14 16:34:26 2023 +0000, Henri Verbeet wrote:
> > ```diff
> > -#if defined(SONAME_LIBDXCOMPILER) && !defined(VKD3D_CROSSTEST)
> > +#if defined(SONAME_LIBDXCOMPILER) || defined(VKD3D_CROSSTEST)
> > ```
>
> Should that just be "#if defined(SONAME_LIBDXCOMPILER)"? We could
> perhaps consider defining SONAME_LIBDXCOMPILER to "dxcompiler.dll" if it
> isn't already defined and we have VKD3D_CROSSTEST, but in principle I
> don't think VKD3D_CROSSTEST needs special handling here.
> Defining `SONAME_LIBDXCOMPILER` when the dxcompiler library is not indeed available means that tests start failing. If no soname was specified or detected at configuration time, I don't think we should even try to use that library.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519#note_55995