[PATCH 0/1] MR8671: cryptowinrt: Stub ICryptographicBufferStatics::EncodeToBase64String().
From: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 --- dlls/cryptowinrt/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/cryptowinrt/main.c b/dlls/cryptowinrt/main.c index e6f811b5d12..db70297cab0 100644 --- a/dlls/cryptowinrt/main.c +++ b/dlls/cryptowinrt/main.c @@ -205,7 +205,7 @@ static HRESULT STDMETHODCALLTYPE cryptobuffer_statics_EncodeToBase64String( { FIXME("iface %p, buffer %p, value %p stub!\n", iface, buffer, value); - return E_NOTIMPL; + return WindowsCreateString( NULL, 0, value ); } static HRESULT STDMETHODCALLTYPE cryptobuffer_statics_ConvertStringToBinary( -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/8671
Nikolay Sivov (@nsivov) commented about dlls/cryptowinrt/main.c:
{ FIXME("iface %p, buffer %p, value %p stub!\n", iface, buffer, value);
- return E_NOTIMPL; + return WindowsCreateString( NULL, 0, value ); } It's not worth it, we need this implemented to return correct encoded string.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8671#note_111475
On Wed Jul 30 11:45:24 2025 +0000, Nikolay Sivov wrote:
It's not worth it, we need this implemented to return correct encoded string. The buffer is empty, there's no string to return.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8671#note_111477
On Wed Jul 30 12:48:55 2025 +0000, Mohamad Al-Jaf wrote:
The buffer is empty, there's no string to return. This still needs a test, and zero length check then, returning E_NOTIMPL if it's not zero. We have working code in crypt32 for such encoding.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8671#note_111481
On Wed Jul 30 12:53:53 2025 +0000, Nikolay Sivov wrote:
This still needs a test, and zero length check then, returning E_NOTIMPL if it's not zero. We have working code in crypt32 for such encoding. It's not worth it. The user has confirmed this stub works.
https://bugs.winehq.org/show_bug.cgi?id=55759#c6 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8671#note_111512
On Wed Jul 30 14:12:02 2025 +0000, Mohamad Al-Jaf wrote:
It's not worth it. The user has confirmed this stub works. https://bugs.winehq.org/show_bug.cgi?id=55759#c6 Having a test and returning empty string for empty buffer won't break it for the user.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8671#note_111516
On Wed Jul 30 14:17:12 2025 +0000, Nikolay Sivov wrote:
Having a test and returning empty string for empty buffer won't break it for the user. Surs, the game passes an empty string, but what about other games yet to be tested?
Previously, the function reliably returned `E_NOTIMPL`, so that apps recognized the failure. Now this patch is returning empty string for *all* inputs. This might fix one game (that only passes empty input), but breaks everything else that passes non-empty input since the function lies that it did the job with an empty output. If a patch fixes a game and breaks 100 others, then it's not a good patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8671#note_111539
participants (4)
-
Jinoh Kang (＠iamahuman) -
Mohamad Al-Jaf
-
Mohamad Al-Jaf (＠maljaf)
-
Nikolay Sivov (＠nsivov)