[PATCH 0/1] MR5395: dwrite/shape: Fully initialize shaping context when getting glyph positions (Valgrind).

[Nikolay Sivov (＠nsivov)]

Actual issue is uninitialized has_gpos_attachment flag, it might be harmless in practice
but it's better to avoid.

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5395

[PATCH 1/1] dwrite/shape: Fully initialize shaping context when getting glyph positions (Valgrind).

[Nikolay Sivov]

From: Nikolay Sivov <nsivov(a)codeweavers.com>

Actual issue is uninitialized has_gpos_attachment flag, it might be harmless in practice
but it's better to avoid.

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/dwrite/analyzer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/dwrite/analyzer.c b/dlls/dwrite/analyzer.c
index 8f7327278d7..0fab5b7142e 100644
--- a/dlls/dwrite/analyzer.c
+++ b/dlls/dwrite/analyzer.c
@@ -1592,7 +1592,7 @@ static HRESULT WINAPI dwritetextanalyzer_GetGlyphPlacements(IDWriteTextAnalyzer2
     UINT32 const* feature_range_lengths, UINT32 feature_ranges, float *advances, DWRITE_GLYPH_OFFSET *offsets)
 {
     const struct dwritescript_properties *scriptprops;
-    struct scriptshaping_context context;
+    struct scriptshaping_context context = { 0 };
     struct dwrite_fontface *font_obj;
     unsigned int i;
     HRESULT hr;
@@ -1666,7 +1666,7 @@ static HRESULT WINAPI dwritetextanalyzer_GetGdiCompatibleGlyphPlacements(IDWrite
     UINT32 const* feature_range_lengths, UINT32 feature_ranges, float *advances, DWRITE_GLYPH_OFFSET *offsets)
 {
     const struct dwritescript_properties *scriptprops;
-    struct scriptshaping_context context;
+    struct scriptshaping_context context = { 0 };
     DWRITE_MEASURING_MODE measuring_mode;
     struct dwrite_fontface *font_obj;
     unsigned int i;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5395