[PATCH 0/1] MR8613: cfgmgr32: Fix double-free of property buffers.

[Yuxuan Shui (＠yshui)]

Fixes: a4bae92c7de487fa3e33ed2635244c0f49d0d2f0

Introduced in !8478

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8613

[PATCH 1/1] cfgmgr32: Fix double-free of property buffers.

[Yuxuan Shui]

From: Yuxuan Shui <yshui(a)codeweavers.com>

Fixes: a4bae92c7de487fa3e33ed2635244c0f49d0d2f0
---
 dlls/cfgmgr32/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/cfgmgr32/main.c b/dlls/cfgmgr32/main.c
index 4ba2aee672d..6f3b058c237 100644
--- a/dlls/cfgmgr32/main.c
+++ b/dlls/cfgmgr32/main.c
@@ -611,7 +611,7 @@ static HRESULT device_query_context_add_object( DEV_OBJECT obj, void *data )
     LeaveCriticalSection( &ctx->cs );
 
     for (i = 0; i < obj.cPropertyCount; i++)
-        free( props->Buffer );
+        free( props[i].Buffer );
     free( props );
     return hr;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8613

[Vibhav Pant (＠vibhavp)]

Oops, thank you!

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8613#note_110552

[PATCH 0/1] MR8613: cfgmgr32: Fix double-free of property buffers. - approved

[Vibhav Pant (＠vibhavp)]

This merge request was approved by Vibhav Pant.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8613

[Yuxuan Shui (＠yshui)]

First victim of [ASan CI tests](https://gitlab.winehq.org/yshui/wine/-/jobs/175149/viewer#L525) XD

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8613#note_110556