[PATCH 0/1] MR1096: mmdevapi: Set the name of internal threads.

[Brendan Shanks (＠bshanks)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1096

[PATCH 1/1] mmdevapi: Set the name of internal threads.

[Brendan Shanks]

From: Brendan Shanks <bshanks(a)codeweavers.com>

---
 dlls/mmdevapi/devenum.c | 2 ++
 dlls/mmdevapi/main.c    | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
index bfeb3f3ecd8..69e13a498cf 100644
--- a/dlls/mmdevapi/devenum.c
+++ b/dlls/mmdevapi/devenum.c
@@ -1163,6 +1163,8 @@ static DWORD WINAPI notif_thread_proc(void *user)
     WCHAR out_name[64], vout_name[64], in_name[64], vin_name[64];
     DWORD size;
 
+    SetThreadDescription(GetCurrentThread(), L"wine_mmdevapi_notification");
+
     lstrcpyW(reg_key, drv_keyW);
     lstrcatW(reg_key, L"\\");
     lstrcatW(reg_key, drvs.module_name);
diff --git a/dlls/mmdevapi/main.c b/dlls/mmdevapi/main.c
index 5e0e6728763..abc55a74fda 100644
--- a/dlls/mmdevapi/main.c
+++ b/dlls/mmdevapi/main.c
@@ -381,6 +381,8 @@ static DWORD WINAPI activate_async_threadproc(void *user)
 {
     struct activate_async_op *op = user;
 
+    SetThreadDescription(GetCurrentThread(), L"wine_mmdevapi_actvate_async");
+
     IActivateAudioInterfaceCompletionHandler_ActivateCompleted(op->callback, &op->IActivateAudioInterfaceAsyncOperation_iface);
 
     IActivateAudioInterfaceAsyncOperation_Release(&op->IActivateAudioInterfaceAsyncOperation_iface);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1096

[PATCH 1/1] mmdevapi: Set the name of internal threads.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125105

Your paranoid android.


=== debian11 (32 bit zh:CN report) ===

mmdevapi:
render.c:1116: Test marked flaky: Position 54184 too far after playing 100ms

=== debian11 (build log) ===

Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24745.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24745.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24745.

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/mmdevapi/main.c:
> {
>      struct activate_async_op *op = user;
>
> +    SetThreadDescription(GetCurrentThread(), L"wine_mmdevapi_actvate_async");
    SetThreadDescription(GetCurrentThread(), L"wine_mmdevapi_activate_async");

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1096#note_11467

[Brendan Shanks (＠bshanks)]

On Thu Oct 20 07:29:36 2022 +0000, Huw Davies wrote:
> ```suggestion:-0+0
>     SetThreadDescription(GetCurrentThread(), L"wine_mmdevapi_activate_async");
> ```

Ah good catch, thanks!

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1096#note_11543