[PATCH 0/1] MR1809: gdiplus: Use width replace height in GdipCreateBitmapFromHICON.
Signed-off-by: caibb2018 <1204611687(a)qq.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1809
From: caibb2018 <1204611687(a)qq.com> Signed-off-by: caibb2018 <1204611687(a)qq.com> --- dlls/gdiplus/image.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index 101e7ae1c93..a549390c4c0 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -1698,7 +1698,7 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromHICON(HICON hicon, GpBitmap** bitmap) for (y=0; y<height; y++) { dst = (DWORD*)dst_row; - for (x=0; x<height; x++) + for (x=0; x<width; x++) { DWORD src_value = *src++; if (src_value) @@ -1718,7 +1718,7 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromHICON(HICON hicon, GpBitmap** bitmap) for (y=0; y<height; y++) { dst = (DWORD*)dst_row; - for (x=0; x<height; x++) + for (x=0; x<width; x++) *dst++ |= 0xff000000; dst_row += lockeddata.Stride; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1809
You'll need to use your real name on both your gitlab profile and the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1809#note_19566
All changes ending up being fixed as part of https://gitlab.winehq.org/wine/wine/-/merge_requests/3613. Please close this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1809#note_43043
This merge request was closed by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1809
participants (4)
-
caibb2018 -
caibb2018 (@caibb2018) -
Esme Povirk (@madewokherd) -
Jeffrey Smith (@whydoubt)