Re: [PATCH v4 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
29 May
2024
29 May
'24
10:50 a.m.
It looks like most of the issues @nsivov pointed out [here](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.org/thre...) are yet to be addressed. A few other things: - `pidlFQ` should be freed with `ILFree()` - Let's call it something less opaque like `full_pidl` - Switch to using `malloc()` / `free()` - If we really need the string functions, let's use `wcscpy()` etc -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_71626
571
Age (days ago)
571
Last active (days ago)
0 comments
1 participants
participants (1)
-
Huw Davies (@huw)