[PATCH 0/1] MR6464: msiexec: Fix allocation to include NULL terminator.

[Esme Povirk (＠madewokherd)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57163

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6464

[PATCH 1/1] msiexec: Fix allocation to include NULL terminator.

[Esme Povirk]

From: Esme Povirk <esme(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57163
---
 programs/msiexec/msiexec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/msiexec/msiexec.c b/programs/msiexec/msiexec.c
index 065730c7ff1..e83f4b5f33e 100644
--- a/programs/msiexec/msiexec.c
+++ b/programs/msiexec/msiexec.c
@@ -637,7 +637,7 @@ static WCHAR *remove_quotes( const WCHAR *filename )
     int len = wcslen( filename );
     WCHAR *ret;
 
-    if (!(ret = malloc( len * sizeof(WCHAR) ))) return NULL;
+    if (!(ret = malloc( (len + 1) * sizeof(WCHAR) ))) return NULL;
     if (*ptr == '"')
     {
         ptr++;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6464

[PATCH 1/1] msiexec: Fix allocation to include NULL terminator.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=148329

Your paranoid android.


=== debian11b (64 bit WoW report) ===

dinput:
hotplug.c:194: Test failed: 0x700: GetDeviceState returned 0
hotplug.c:196: Test failed: 0x700: GetDeviceState returned 0
hotplug.c:198: Test failed: 0x700: GetDeviceData returned 0
hotplug.c:200: Test failed: 0x700: Poll returned: 0x1
hotplug.c:203: Test failed: 0x700: Acquire returned 0x1
hotplug.c:205: Test failed: 0x700: GetDeviceState returned 0x8007001e
hotplug.c:207: Test failed: 0x700: GetDeviceData returned 0x8007001e