Re: [PATCH v2 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
28 May
2024
28 May
'24
9:22 p.m.
Nikolay Sivov (@nsivov) commented about dlls/mf/main.c:
- FIXME("%p, %p, %p.\n", attributes, sources, count); + GUID source_type; + HRESULT hr; + + TRACE("%p, %p, %p.\n", attributes, sources, ret_count);
- if (!attributes || !sources || !count) + if (!attributes || !sources || !ret_count) return E_INVALIDARG;
- *count = 0; + if (FAILED(hr = IMFAttributes_GetGUID(attributes, &MF_DEVSOURCE_ATTRIBUTE_SOURCE_TYPE, &source_type))) + return hr;
- return S_OK; + if (IsEqualIID(&source_type, &MF_DEVSOURCE_ATTRIBUTE_SOURCE_TYPE_VIDCAP_GUID)) It makes no difference in practice, but IsEqualGUID() is a better fit.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71439
572
Age (days ago)
572
Last active (days ago)
0 comments
1 participants
participants (1)
-
Nikolay Sivov (@nsivov)