Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm1.c:
> write_sm1_unary_op(ctx, buffer, D3DSIO_FRC, &instr->reg, &arg1->reg, D3DSPSM_NONE);
>              break;
>
> +        case HLSL_OP2_DOT:
> +            switch (dst_type->base_type)
> +            {
> +                case HLSL_TYPE_FLOAT:

I think that SM1 basically only supports float, which is why all the other operations do not have this switch on the data type. I am not really confident on the details of this, but I guess that only float operations should arrive here anyway.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22624