Re: [PATCH v5 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
8 Jul
2023
8 Jul
'23
6:37 a.m.
On Fri Jul 7 20:46:54 2023 +0000, Nikolay Sivov wrote:
Shouldn't this duplicate the string? That makes sense, it indeed duplicates the string on Windows based on the test I added. I'm not sure but there might be an issue with the way Wine handles HSTRING duplication as it's failing to create the right HSTRING.
https://testbot.winehq.org/JobDetails.pl?Key=134593 All I did was change it to `WindowsDuplicateString( name, &impl->rawname );` and add `WindowsDeleteString( impl->rawname );` under `IHostName::Release()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3249#note_38386
889
Age (days ago)
889
Last active (days ago)
0 comments
1 participants
participants (1)
-
Mohamad Al-Jaf (@maljaf)