[PATCH 0/2] MR3453: DECLSPEC_HIDDEN usage setupapi/wmp

[Alistair Leslie-Hughes (＠alesliehughes)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3453

[PATCH 1/2] wmp: Remove DECLSPEC_HIDDEN usage.

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

---
 dlls/wmp/wmp_private.h | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/dlls/wmp/wmp_private.h b/dlls/wmp/wmp_private.h
index ffeaca09a47..b5e580d91ca 100644
--- a/dlls/wmp/wmp_private.h
+++ b/dlls/wmp/wmp_private.h
@@ -36,7 +36,7 @@ TID_LIST
     LAST_tid
 } typeinfo_id;
 
-HRESULT get_typeinfo(typeinfo_id tid, ITypeInfo **typeinfo) DECLSPEC_HIDDEN;
+HRESULT get_typeinfo(typeinfo_id tid, ITypeInfo **typeinfo);
 
 typedef struct {
     IConnectionPoint IConnectionPoint_iface;
@@ -111,22 +111,22 @@ struct WindowsMediaPlayer {
     HWND msg_window;
 };
 
-BOOL init_player(WindowsMediaPlayer*) DECLSPEC_HIDDEN;
-void destroy_player(WindowsMediaPlayer*) DECLSPEC_HIDDEN;
-WMPMedia *unsafe_impl_from_IWMPMedia(IWMPMedia *iface) DECLSPEC_HIDDEN;
-WMPPlaylist *unsafe_impl_from_IWMPPlaylist(IWMPPlaylist *iface) DECLSPEC_HIDDEN;
-HRESULT create_media_from_url(BSTR url, double duration, IWMPMedia **ppMedia) DECLSPEC_HIDDEN;
-HRESULT create_playlist(BSTR name, BSTR url, LONG count, IWMPPlaylist **ppPlaylist) DECLSPEC_HIDDEN;
-void ConnectionPointContainer_Init(WindowsMediaPlayer *wmp) DECLSPEC_HIDDEN;
-void ConnectionPointContainer_Destroy(WindowsMediaPlayer *wmp) DECLSPEC_HIDDEN;
-void call_sink(ConnectionPoint *This, DISPID dispid, DISPPARAMS *dispparams) DECLSPEC_HIDDEN;
+BOOL init_player(WindowsMediaPlayer*);
+void destroy_player(WindowsMediaPlayer*);
+WMPMedia *unsafe_impl_from_IWMPMedia(IWMPMedia *iface);
+WMPPlaylist *unsafe_impl_from_IWMPPlaylist(IWMPPlaylist *iface);
+HRESULT create_media_from_url(BSTR url, double duration, IWMPMedia **ppMedia);
+HRESULT create_playlist(BSTR name, BSTR url, LONG count, IWMPPlaylist **ppPlaylist);
+void ConnectionPointContainer_Init(WindowsMediaPlayer *wmp);
+void ConnectionPointContainer_Destroy(WindowsMediaPlayer *wmp);
+void call_sink(ConnectionPoint *This, DISPID dispid, DISPPARAMS *dispparams);
 
-HRESULT WINAPI WMPFactory_CreateInstance(IClassFactory*,IUnknown*,REFIID,void**) DECLSPEC_HIDDEN;
+HRESULT WINAPI WMPFactory_CreateInstance(IClassFactory*,IUnknown*,REFIID,void**);
 
-void unregister_wmp_class(void) DECLSPEC_HIDDEN;
-void unregister_player_msg_class(void) DECLSPEC_HIDDEN;
+void unregister_wmp_class(void);
+void unregister_player_msg_class(void);
 
-extern HINSTANCE wmp_instance DECLSPEC_HIDDEN;
+extern HINSTANCE wmp_instance;
 
 static inline HRESULT return_bstr(const WCHAR *value, BSTR *p)
 {
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/3453

[PATCH 2/2] setupapi: Remove DECLSPEC_HIDDEN usage.

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

---
 dlls/setupapi/setupapi_private.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/dlls/setupapi/setupapi_private.h b/dlls/setupapi/setupapi_private.h
index df218314d6e..9d3d19c84c0 100644
--- a/dlls/setupapi/setupapi_private.h
+++ b/dlls/setupapi/setupapi_private.h
@@ -45,7 +45,7 @@
 
 #define PNF_HEADER L"Wine PNF header\n"
 
-extern HINSTANCE SETUPAPI_hInstance DECLSPEC_HIDDEN;
+extern HINSTANCE SETUPAPI_hInstance;
 
 static inline char *strdupWtoA( const WCHAR *str )
 {
@@ -82,9 +82,9 @@ char *  WINAPI UnicodeToMultiByte( const WCHAR *str, UINT code_page ) __WINE_DEA
 /* string substitutions */
 
 struct inf_file;
-extern const WCHAR *DIRID_get_string( int dirid ) DECLSPEC_HIDDEN;
-extern const WCHAR *PARSER_get_inf_filename( HINF hinf ) DECLSPEC_HIDDEN;
-extern WCHAR *PARSER_get_dest_dir( INFCONTEXT *context ) DECLSPEC_HIDDEN;
+extern const WCHAR *DIRID_get_string( int dirid );
+extern const WCHAR *PARSER_get_inf_filename( HINF hinf );
+extern WCHAR *PARSER_get_dest_dir( INFCONTEXT *context );
 
 /* support for ANSI queue callback functions */
 
@@ -94,11 +94,11 @@ struct callback_WtoA_context
     PSP_FILE_CALLBACK_A orig_handler;
 };
 
-UINT CALLBACK QUEUE_callback_WtoA( void *context, UINT notification, UINT_PTR, UINT_PTR ) DECLSPEC_HIDDEN;
+UINT CALLBACK QUEUE_callback_WtoA( void *context, UINT notification, UINT_PTR, UINT_PTR );
 
-extern OSVERSIONINFOW OsVersionInfo DECLSPEC_HIDDEN;
+extern OSVERSIONINFOW OsVersionInfo;
 
-extern BOOL create_fake_dll( const WCHAR *name, const WCHAR *source ) DECLSPEC_HIDDEN;
-extern void cleanup_fake_dlls(void) DECLSPEC_HIDDEN;
+extern BOOL create_fake_dll( const WCHAR *name, const WCHAR *source );
+extern void cleanup_fake_dlls(void);
 
 #endif /* __SETUPAPI_PRIVATE_H */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3453

[PATCH 0/2] MR3453: DECLSPEC_HIDDEN usage setupapi/wmp - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3453