[PATCH v2 0/1] MR9345: d2d1: Fix missing geometry assignment in command list recording
The d2d_command_list_draw_geometry() function didn't store the 'geometry', this may cause an error when command replay. Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- v2: d2d1: Fix missing geometry assignment in command list recording https://gitlab.winehq.org/wine/wine/-/merge_requests/9345
From: YeshunYe <yeyeshun(a)uniontech.com> The d2d_command_list_draw_geometry() function didn't store the 'geometry', this may cause an error when command replay. Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> --- dlls/d2d1/command_list.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/d2d1/command_list.c b/dlls/d2d1/command_list.c index 27c2bf3db41..4d81f0f1ccf 100644 --- a/dlls/d2d1/command_list.c +++ b/dlls/d2d1/command_list.c @@ -795,6 +795,7 @@ void d2d_command_list_draw_geometry(struct d2d_command_list *command_list, command = d2d_command_list_require_space(command_list, sizeof(*command)); command->c.op = D2D_COMMAND_DRAW_GEOMETRY; + command->geometry = geometry; command->brush = brush; command->stroke_width = stroke_width; command->stroke_style = stroke_style; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9345
On Mon Nov 3 08:22:48 2025 +0000, Nikolay Sivov wrote:
The fix is good, but please move this before 'brush' assignment to keep everything in argument order. Good advice.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9345#note_120447
participants (2)
-
Yeshun Ye (＠yeyeshun) -
YeshunYe