[PATCH 0/1] MR10226: change vkb hidraw handling to catchall

[Ty (＠chaos)]

now supports new modular hardware and user custom pid


reason:
in consulting with a large number of vkb device users it was found their pid is arbitrary for modular items (pid gets xor'd for each component plugged in), and devices can be software modified to have different numbers of axis/buttons, or user modified pid's. vkb have no known (to me) VID collisions so should be safe to just catch-all.

Contingency for failure:
if a hypothetical future device existed from vkb that didnt want hidraw (xinput gamepad), an explicit exemption for that device pid would be the solution.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10226

[PATCH 1/1] change vkb hidraw handling to catchall now supports new modular hardware and user custom pid

[Ty]

From: Ty <[e-mail]>

---
 dlls/winebus.sys/main.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/dlls/winebus.sys/main.c b/dlls/winebus.sys/main.c
index 4e2227bb636..7ba904b09f2 100644
--- a/dlls/winebus.sys/main.c
+++ b/dlls/winebus.sys/main.c
@@ -560,13 +560,8 @@ static BOOL is_hidraw_enabled(WORD vid, WORD pid, const USAGE_AND_PAGE *usages,
         if (pid == 0x1839) prefer_hidraw = TRUE; /* Fanatec ClubSport Pedals v1/v2 */
         break;
     case 0x231d:
-        /* comes with 128 buttons in the default configuration */
-        if (buttons == 128) prefer_hidraw = TRUE;
-        /* if customized, less than 128 buttons may be shown, decide by PID */
-        if (pid == 0x0200) prefer_hidraw = TRUE; /* VKBsim Gladiator EVO Right Grip */
-        if (pid == 0x0201) prefer_hidraw = TRUE; /* VKBsim Gladiator EVO Left Grip */
-        if (pid == 0x0126) prefer_hidraw = TRUE; /* VKB-Sim Space Gunfighter */
-        if (pid == 0x0127) prefer_hidraw = TRUE; /* VKB-Sim Space Gunfighter L */
+        /* all vkb devices require hidraw, vkb pid & button/axis count are variable by user & modular hardware config */
+        prefer_hidraw = TRUE;
         break;
     case 0x3344:
         /* all VPC devices require hidraw, have variable numbers of axis/buttons, & in many cases
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10226

[Ty (＠chaos)]

user verification at https://gitlab.winehq.org/winehq/winehq/-/issues/105 (unsure how to un-mark confidential)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10226#note_130968