[PATCH 0/2] MR2090: taskkill, taskmgr: Use exit code 1 when terminating processes.

[Brendan Shanks (＠bshanks)]

It isn't officially documented but `taskmgr` and `taskkill` on Windows both use exit code 1 when terminating processes, and Chromium treats those exit codes differently (see [kill.h](https://source.chromium.org/chromium/chromium/src/+/main:base/process/kill.h...)).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2090

[PATCH 1/2] taskmgr: Use exit code 1 when terminating processes.

[Brendan Shanks]

From: Brendan Shanks <bshanks(a)codeweavers.com>

---
 programs/taskmgr/endproc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/programs/taskmgr/endproc.c b/programs/taskmgr/endproc.c
index 498186212b7..0d2752be9ac 100644
--- a/programs/taskmgr/endproc.c
+++ b/programs/taskmgr/endproc.c
@@ -83,7 +83,7 @@ void ProcessPage_OnEndProcess(void)
         return;
     }
 
-    if (!TerminateProcess(hProcess, 0))
+    if (!TerminateProcess(hProcess, 1))
     {
         GetLastErrorText(wstrErrorText, ARRAY_SIZE(wstrErrorText));
         MessageBoxW(hMainWnd, wstrErrorText,wszUnable2Terminate, MB_OK|MB_ICONSTOP);
@@ -133,7 +133,7 @@ void ProcessPage_OnEndProcessTree(void)
         return;
     }
 
-    if (!TerminateProcess(hProcess, 0))
+    if (!TerminateProcess(hProcess, 1))
     {
         GetLastErrorText(wstrErrorText, ARRAY_SIZE(wstrErrorText));
         MessageBoxW(hMainWnd, wstrErrorText,wszUnable2Terminate, MB_OK|MB_ICONSTOP);
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/2090

[PATCH 2/2] taskkill: Use exit code 1 when terminating processes.

[Brendan Shanks]

From: Brendan Shanks <bshanks(a)codeweavers.com>

---
 programs/taskkill/taskkill.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/programs/taskkill/taskkill.c b/programs/taskkill/taskkill.c
index 2904e64f40a..424e87b9a44 100644
--- a/programs/taskkill/taskkill.c
+++ b/programs/taskkill/taskkill.c
@@ -341,7 +341,7 @@ static int terminate_processes(void)
                 continue;
             }
 
-            if (!TerminateProcess(process, 0))
+            if (!TerminateProcess(process, 1))
             {
                 taskkill_message_printfW(STRING_TERMINATE_FAILED, task_list[i]);
                 status_code = 1;
@@ -381,7 +381,7 @@ static int terminate_processes(void)
                         continue;
                     }
 
-                    if (!TerminateProcess(process, 0))
+                    if (!TerminateProcess(process, 1))
                     {
                         taskkill_message_printfW(STRING_TERMINATE_FAILED, task_list[i]);
                         status_code = 1;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2090