[PATCH 0/1] MR7940: dmsynth: Don't report an underrun when current equals write position

[Michael Stefaniuc (＠mstefani)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57575

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7940

[PATCH 1/1] dmsynth: Don't report an underrun when current equals write position

[Michael Stefaniuc]

From: Michael Stefaniuc <mstefani(a)winehq.org>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57575
---
 dlls/dmsynth/synthsink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dmsynth/synthsink.c b/dlls/dmsynth/synthsink.c
index c0ac7871f9a..dd0066e828f 100644
--- a/dlls/dmsynth/synthsink.c
+++ b/dlls/dmsynth/synthsink.c
@@ -91,7 +91,7 @@ static HRESULT synth_sink_write_data(struct synth_sink *sink, IDirectSoundBuffer
 
         if (FAILED(hr = IDirectSoundBuffer_GetCurrentPosition(buffer, &play_pos, &write_pos))) return hr;
 
-        if (current_pos - play_pos <= write_pos - play_pos)
+        if (current_pos - play_pos < write_pos - play_pos)
         {
             ERR("Underrun detected, sink %p, play pos %#lx, write pos %#lx, current pos %#lx!\n",
                     buffer, play_pos, write_pos, current_pos);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7940

[Michael Stefaniuc (＠mstefani)]

@rbernon am I missing anything or is the fix so trivial?\
As mentioned in bug 57575 it is enough to remove the underrun console spam for me from Street Fighter X Mega Man.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7940#note_102265

[Michael Stefaniuc (＠mstefani)]

There is no dmsyth test failure but the test seems to be crashing unrelated to this change.
Those crashes started after the recent mmdevapi library loading changes.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7940#note_102306