[PATCH 0/1] MR2975: msi: Fix memory leak in ready_media (scan-build).

[Alex Henrie (＠alexhenrie)]

base_url was never freed, and can simply be enlarged instead of copying
it to a new buffer.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2975

[PATCH 1/1] msi: Fix memory leak in ready_media (scan-build).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

base_url was never freed, and can simply be enlarged instead of copying
it to a new buffer.
---
 dlls/msi/media.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/msi/media.c b/dlls/msi/media.c
index 513e04b1b7e..50673f99cae 100644
--- a/dlls/msi/media.c
+++ b/dlls/msi/media.c
@@ -855,11 +855,11 @@ UINT ready_media( MSIPACKAGE *package, BOOL compressed, MSIMEDIAINFO *mi )
             WCHAR temppath[MAX_PATH], *p, *url;
 
             free( cabinet_file );
-            if (!(url = malloc( (wcslen( base_url ) + wcslen( mi->cabinet ) + 1) * sizeof(WCHAR) )))
+            if (!(url = realloc( base_url, (wcslen( base_url ) + wcslen( mi->cabinet ) + 1) * sizeof(WCHAR) )))
             {
+                free( base_url );
                 return ERROR_OUTOFMEMORY;
             }
-            lstrcpyW( url, base_url );
             lstrcatW( url, mi->cabinet );
             if ((rc = msi_download_file( url, temppath )) != ERROR_SUCCESS)
             {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2975

[PATCH 0/1] MR2975: msi: Fix memory leak in ready_media (scan-build). - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2975