Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm1.c:
> struct hlsl_ir_expr *expr = hlsl_ir_expr(instr);
>      struct hlsl_ir_node *arg1 = expr->operands[0].node;
>      struct hlsl_ir_node *arg2 = expr->operands[1].node;
> +    struct hlsl_ir_node *arg3 = expr->operands[2].node;
> +    const struct hlsl_type *dst_type = expr->node.data_type;
> +    struct vkd3d_string_buffer *dst_type_string;
>
> assert(instr->reg.allocated);
>
> +    if (!(dst_type_string = hlsl_type_to_string(ctx, dst_type)))

This is never released. It should be passed to `hlsl_release_string_buffer()`.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22620