[PATCH 0/16] MR3773: mshtml: Implement a unified QueryInterface on the dispex, part 2.
-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3773
Jacek Caban (@jacek) commented about dlls/mshtml/htmlevent.c:
return CONTAINING_RECORD(iface, DOMEvent, dispex); }
+static void *DOMEvent_query_interface(DispatchEx *dispex, REFIID riid) +{ + DOMEvent *This = DOMEvent_from_DispatchEx(dispex); + + if(IsEqualGUID(&IID_IDOMEvent, riid)) + return &This->IDOMEvent_iface; + if(This->query_interface)
This seems like a good opportunity to get rid of query_interface from DOMEvent object. Anyway, this MR has too many commit, please split it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3773#note_44701
On Fri Sep 8 14:52:15 2023 +0000, Jacek Caban wrote:
This seems like a good opportunity to get rid of query_interface from DOMEvent object. Anyway, this MR has too many commit, please split it. Oh, I was going to do that on follow up MR. But I'll split it anyway.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3773#note_44705
On Fri Sep 8 15:23:06 2023 +0000, Gabriel Ivăncescu wrote:
Oh, I was going to do that on follow up MR. But I'll split it anyway. I mean, it's fine to do all event objects in a single commit. But this MR has too many commits in total already.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3773#note_44706
participants (2)
-
Gabriel Ivăncescu -
Jacek Caban (@jacek)