[PATCH 0/1] MR3058: kerberos: Avoid potentially uninitialized variable (clang-scan)

[Fabian Maurer (＠DarkShadow44)]

When there are no caches, this variable would be uninitialized.
Reported by clang-scan.
Not sure if that can ever happen, but IMHO initializing doesn't do harm.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3058

[PATCH 1/1] kerberos: Avoid potentially uninitialized variable (clang-scan)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de>
---
 dlls/kerberos/unixlib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/kerberos/unixlib.c b/dlls/kerberos/unixlib.c
index 45cf494aa70..1f5b249acd4 100644
--- a/dlls/kerberos/unixlib.c
+++ b/dlls/kerberos/unixlib.c
@@ -305,7 +305,7 @@ static NTSTATUS copy_tickets_to_client( struct ticket_list *list, KERB_QUERY_TKT
 
 static NTSTATUS kerberos_fill_ticket_list( struct ticket_list *list )
 {
-    NTSTATUS status;
+    NTSTATUS status = STATUS_UNSUCCESSFUL;
     krb5_error_code err;
     krb5_context ctx;
     krb5_cccol_cursor cursor = NULL;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3058

[PATCH 1/1] kerberos: Avoid potentially uninitialized variable (clang-scan)

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=133742

Your paranoid android.


=== debian11 (32 bit report) ===

secur32:
secur32.c:485: Test failed: got c0000001
secur32.c:486: Test failed: got 6553320
Unhandled exception: page fault on read access to 0xffff0000 in 32-bit code (0x00411373).

[Fabian Maurer (＠DarkShadow44)]

Any news on this?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3058#note_38075

[Hans Leidekker (＠hans)]

The patch introduces a test failure.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3058#note_38102