Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
19 Oct
2022
19 Oct
'22
11:37 a.m.
On Tue Oct 18 10:04:58 2022 +0000, Matteo Bruni wrote:
Can you reorder the fields such that the values to set are all at the start and the expected values all at the end? E.g.: ```suggestion:-10+0 struct test_set_raw_data_value { const char *param_name; D3DXPARAMETER_TYPE param_type; const void *data; unsigned int data_size; unsigned int offset; HRESULT expected_hr; const void *expected_data; unsigned int expected_data_size; }; ``` Done in v3 of the patch.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11310
1159
Age (days ago)
1159
Last active (days ago)
0 comments
1 participants
participants (1)
-
Patrick Hibbs (@hibbsncc1701)