[PATCH 0/1] MR1127: wintrust: Add a trailing linefeed to an ERR() message.

[Francois Gouget (＠fgouget)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1127

[PATCH 1/1] wintrust: Add a trailing linefeed to an ERR() message.

[Francois Gouget]

From: Francois Gouget <fgouget(a)free.fr>

Also add a full stop to match the other ERR() messages in
load_secondary_signatures().
---
AFAIK trailing full stops are not really standard in Wine but it seems
to be what this area of the code is going for.
---
 dlls/wintrust/softpub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wintrust/softpub.c b/dlls/wintrust/softpub.c
index 06b178a98b9..48fd78682b1 100644
--- a/dlls/wintrust/softpub.c
+++ b/dlls/wintrust/softpub.c
@@ -855,7 +855,7 @@ static void load_secondary_signatures(CRYPT_PROVIDER_DATA *data, HCRYPTMSG msg)
 
         if (!(s->rhSecondarySigs = data->psPfns->pfnAlloc(attrs->rgAttr[i].cValue * sizeof(*s->rhSecondarySigs))))
         {
-            ERR("No memory");
+            ERR("No memory.\n");
             goto done;
         }
         s->cSecondarySigs = 0;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1127

[PATCH 1/1] wintrust: Add a trailing linefeed to an ERR() message.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125215

Your paranoid android.


=== debian11 (32 bit report) ===

ws2_32:
sock.c:6456: Test succeeded inside todo block: expected timeout

=== debian11 (build log) ===

Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24712.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24712.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24712.