[PATCH 0/1] MR5063: ntdll: Remove stale comment from set_async_direct_result() documentation.
The supplied async handle passed to set_async_direct_result() cannot be NULL. Fixes: 6b16ead607e (ntdll: The async handle passed to set_async_direct_result() cannot be NULL., 2022-09-16) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5063
From: Jinoh Kang <jinoh.kang.kr(a)gmail.com> The supplied async handle passed to set_async_direct_result() cannot be NULL. Fixes: dca8626be5cafe77a55b9bdff19bfb0f42b31e2c --- dlls/ntdll/unix/sync.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/ntdll/unix/sync.c b/dlls/ntdll/unix/sync.c index bfbcaf4a851..7e2927390d3 100644 --- a/dlls/ntdll/unix/sync.c +++ b/dlls/ntdll/unix/sync.c @@ -2620,7 +2620,6 @@ NTSTATUS WINAPI NtWaitForAlertByThreadId( const void *address, const LARGE_INTEG #endif /* Notify direct completion of async and close the wait handle if it is no longer needed. - * This function is a no-op (returns status as-is) if the supplied handle is NULL. */ void set_async_direct_result( HANDLE *async_handle, NTSTATUS status, ULONG_PTR information, BOOL mark_pending ) { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5063
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=142964 Your paranoid android. === debian11b (64 bit WoW report) === adsldp: ldap: Timeout
Fixes: dca8626be5cafe77a55b9bdff19bfb0f42b31e2c
That's not a Wine revision. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5063#note_60737
participants (4)
-
Jinoh Kang -
Jinoh Kang (＠iamahuman)
-
Marvin -
Zebediah Figura (＠zfigura)