[PATCH 0/1] MR4819: ntoskrnl.exe/tests: Use SUOI_FORCEDELETE when uninstalling the driver.
Avoids conflicts with the dinput tests somehow. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52962 The dinput tests have been using that too for a long while without any known issues. It also makes the tests more robust to interruptions and IME have been able to get back to a working state after a test failed to properly uninstall devices. (I've tried renaming dinput inf strings and files to something else but for some reason that's not enough and ntoskrnl.exe tests still fail on this call) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4819
From: Rémi Bernon <rbernon(a)codeweavers.com> Avoids conflicts with the dinput tests somehow. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52962 --- dlls/ntoskrnl.exe/tests/ntoskrnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c index 5a47523cf71..36983e2c8b8 100644 --- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c @@ -1874,7 +1874,7 @@ static void test_pnp_driver(struct testsign_context *ctx) GetFullPathNameA("winetest.inf", sizeof(path), path, NULL); ret = SetupCopyOEMInfA(path, NULL, 0, 0, dest, sizeof(dest), NULL, &filepart); ok(ret, "Failed to copy INF, error %#lx\n", GetLastError()); - ret = SetupUninstallOEMInfA(filepart, 0, NULL); + ret = SetupUninstallOEMInfA(filepart, SUOI_FORCEDELETE, NULL); ok(ret, "Failed to uninstall INF, error %lu\n", GetLastError()); ret = DeleteFileA("winetest.cat"); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4819
This scares me greatly. If SUOI_FORCEDELETE makes a difference, that implies that something else wasn't properly torn down. Do you still encounter this if you use different hardware/compatible IDs for dinput drivers? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4819#note_57064
participants (2)
-
Rémi Bernon -
Zebediah Figura (＠zfigura)