[PATCH 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK

[Aric Stewart (＠aricstewart)]

Presently the wine file explorer has a create shortcut entry that does nothing. This implements the FCIDM_SHVIEW_CREATELINK command.

This is a patch that was first submitted in 2017 and I unfortunately let the revision request fall unimplemented.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5373

[PATCH 1/1] shell32: Implement FCIDM_SHVIEW_CREATELINK

[Aric Stewart]

From: Aric Stewart <aric(a)codeweavers.com>

---
 dlls/shell32/shlview_cmenu.c | 50 ++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/dlls/shell32/shlview_cmenu.c b/dlls/shell32/shlview_cmenu.c
index cac33c39af7..0f56cd80434 100644
--- a/dlls/shell32/shlview_cmenu.c
+++ b/dlls/shell32/shlview_cmenu.c
@@ -946,6 +946,52 @@ static void DoOpenProperties(ContextMenu *This, HWND hwnd)
 	    FIXME("No property pages found.\n");
 }
 
+
+static void DoCreateLink(ContextMenu *This)
+{
+    IShellLinkW* shelllink;
+    IPersistFile* persistfile;
+    WCHAR wszFilename[MAX_PATH];
+    WCHAR root[MAX_PATH];
+    WCHAR *lnkfile=NULL;
+    LPITEMIDLIST pidlFQ;
+
+    static const WCHAR backslashW[]={'\\','\0'};
+    static const WCHAR lnkW[]={'.','l','n','k','\0'};
+
+    if (FAILED(IShellLink_Constructor(NULL, &IID_IShellLinkW, (LPVOID*)&shelllink)))
+    {
+        ERR("couldn't create ShellLink object\n");
+        return;
+    }
+    pidlFQ = ILCombine(This->pidl, This->apidl[0]);
+    IShellLinkW_SetIDList(shelllink, pidlFQ);
+    SHFree(pidlFQ);
+    _ILSimpleGetTextW(This->apidl[0], (LPVOID)wszFilename, MAX_PATH);
+
+    GetCurrentDirectoryW(MAX_PATH, root);
+    lnkfile=HeapAlloc(GetProcessHeap(), 0, (lstrlenW(root)+1+lstrlenW(wszFilename)+5) * sizeof(*lnkfile));
+    lstrcpyW(lnkfile, root);
+    lstrcatW(lnkfile, backslashW);
+    lstrcatW(lnkfile, wszFilename);
+    lstrcatW(lnkfile, lnkW);
+
+    if (!SUCCEEDED(IShellLinkW_QueryInterface(shelllink, &IID_IPersistFile, (LPVOID*)&persistfile)))
+    {
+        ERR("couldn't get IPersistFile interface\n");
+        IShellLinkW_Release(shelllink);
+        HeapFree(GetProcessHeap(), 0, lnkfile);
+        return;
+    }
+    TRACE("writing link to %s\n", wine_dbgstr_w(lnkfile));
+    if (!SUCCEEDED(IPersistFile_Save(persistfile, lnkfile, FALSE)))
+        ERR("couldn't write link to %s\n", wine_dbgstr_w(lnkfile));
+
+    IPersistFile_Release(persistfile);
+    IShellLinkW_Release(shelllink);
+    HeapFree(GetProcessHeap(), 0, lnkfile);
+}
+
 static HRESULT WINAPI ItemMenu_InvokeCommand(
 	IContextMenu3 *iface,
 	LPCMINVOKECOMMANDINFO lpcmi)
@@ -1014,6 +1060,10 @@ static HRESULT WINAPI ItemMenu_InvokeCommand(
             TRACE("Verb FCIDM_SHVIEW_PROPERTIES\n");
             DoOpenProperties(This, lpcmi->hwnd);
             break;
+        case FCIDM_SHVIEW_CREATELINK:
+            TRACE("Verb FCIDM_SHVIEW_CREATELINK\n");
+            DoCreateLink(This);
+            break;
         default:
             FIXME("Unhandled verb %#x.\n", id);
             return E_INVALIDARG;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5373