[PATCH 0/1] MR1113: include: Add _putenv_s.

[Alex Henrie (＠alexhenrie)]

Needed to compile Tera Term.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1113

[PATCH 1/1] include: Add _putenv_s.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

Needed to compile Tera Term.
---
 include/msvcrt/stdlib.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/msvcrt/stdlib.h b/include/msvcrt/stdlib.h
index a6e1c7eee02..58cbc9de277 100644
--- a/include/msvcrt/stdlib.h
+++ b/include/msvcrt/stdlib.h
@@ -178,6 +178,7 @@ _ACRTIMP int           __cdecl _makepath_s(char*,size_t,const char*,const char*,
 _ACRTIMP size_t        __cdecl _mbstrlen(const char*);
 _ACRTIMP _onexit_t     __cdecl _onexit(_onexit_t);
 _ACRTIMP int           __cdecl _putenv(const char*);
+_ACRTIMP int           __cdecl _putenv_s(const char*,const char*);
 #ifndef _rotl
 _ACRTIMP unsigned int  __cdecl _rotl(unsigned int,int);
 #endif
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1113

[PATCH 1/1] include: Add _putenv_s.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125173

Your paranoid android.


=== debian11 (32 bit report) ===

ddraw:
ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x1000.
ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x3000.

=== debian11 (build log) ===

Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24727.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24727.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24727.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about include/msvcrt/stdlib.h:
> _ACRTIMP size_t        __cdecl _mbstrlen(const char*);
>  _ACRTIMP _onexit_t     __cdecl _onexit(_onexit_t);
>  _ACRTIMP int           __cdecl _putenv(const char*);
> +_ACRTIMP int           __cdecl _putenv_s(const char*,const char*);
> Please change return type to errno_t (please also change it in implementation).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1113#note_11497