Re: [PATCH v5 0/7] MR5319: winemac.drv keyboard layout/dead key fixes

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winemac.drv/keyboard.c:
> if (!len)
>                  break;
>
> +            if (status == noErr && len == 1)
> +            {
> +                CFStringRef stringRef = CFStringCreateWithCharacters(kCFAllocatorDefault, buffer, len);
> +                CFMutableStringRef mutableStringRef = CFStringCreateMutableCopy(kCFAllocatorDefault, 0, stringRef);
> +
> +                CFStringUppercase(mutableStringRef, CFLocaleGetSystem());
> +                if (CFStringGetLength(mutableStringRef) == 1)
> +                    CFStringGetCharacters(mutableStringRef, CFRangeMake(0, 1), buffer);
> +                CFRelease(stringRef);
> +                CFRelease(mutableStringRef);
> +            }

Does we need to support unicode? What about:

```suggestion:-10+0
            if (status == noErr && len == 1 && buffer[0] >= 'a' && buffer[0] <= 'z')
                buffer[0] += 'A' - 'a';
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5319#note_73911