Re: [PATCH v3 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function.
19 Oct
2023
19 Oct
'23
1:35 p.m.
On Thu Oct 19 09:51:46 2023 +0000, Nikolay Sivov wrote:
It does compile, but results are broken. That's what I get on Windows: `shader_runner:683: Section [test], line 51: Test failed: Got {8.40779079e-045, 9.80908925e-045, -1.#QNAN000e+000, 4.20389539e-045}, expected {6.00000000e+000, 7.00000000e+000, -1.00000000e+000, 3.00000000e+000} at (0, 0).` That happens because of the lack of itof conversion on SM3. So ints we set are returned as is, after ceil() is optimized away for integers. I see. So the `probe` part may be deserving of a `todo(sm<4)`. I made patches for that on the second part of !418, but I think that for now it is okay to leave the requirement.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417#note_49293
873
Age (days ago)
873
Last active (days ago)
0 comments
1 participants
participants (1)
-
Francisco Casas (@fcasas)