[PATCH v4 0/1] MR777: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub

[Etaash Mathamsetty (＠etaash.mathamsetty)]

This should help to get the nox android emulator to run  
fixes bug https://bugs.winehq.org/show_bug.cgi?id=46760

--
  v4: MmAllocateContiguousMemorySpecifyCache semi-stub
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/777

[PATCH v4 1/1] MmAllocateContiguousMemorySpecifyCache semi-stub

[Etaash Mathamsetty]

From: Etaash Mathamsetty <etaash.mathamsetty(a)gmail.com>

use NULL for lpAddress

remove mutally exclusive PAGE_NOCACHE in MmWriteCombined
---
 dlls/ntoskrnl.exe/ntoskrnl.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c
index 031e9900544..86f4eccdee2 100644
--- a/dlls/ntoskrnl.exe/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/ntoskrnl.c
@@ -2777,8 +2777,22 @@ PVOID WINAPI MmAllocateContiguousMemorySpecifyCache( SIZE_T size,
                                                      PHYSICAL_ADDRESS BoundaryAddressMultiple,
                                                      MEMORY_CACHING_TYPE CacheType )
 {
-    FIXME(": stub\n");
-    return NULL;
+    DWORD protect = PAGE_READWRITE;
+    FIXME( ": ( %Iu %s %s %s %x ) semi-stub\n", size, wine_dbgstr_longlong(lowest_valid_address.QuadPart), 
+                                            wine_dbgstr_longlong(highest_valid_address.QuadPart), 
+                                            wine_dbgstr_longlong(BoundaryAddressMultiple.QuadPart), CacheType );
+    switch (CacheType)
+    {
+        case MmNonCached:
+            protect |= PAGE_NOCACHE;
+            break;
+        case MmWriteCombined:
+            protect |= PAGE_WRITECOMBINE;
+            break;
+        default:
+            break;
+    }
+    return VirtualAlloc( NULL, size, MEM_RESERVE|MEM_COMMIT, protect );
 }
 
 /***********************************************************************
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/777

[Etaash Mathamsetty (＠etaash.mathamsetty)]

On Mon Sep  5 17:39:01 2022 +0000, **** wrote:
> Marvin replied on the mailing list:
> ```
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=122684
> Your paranoid android.
> === debian11 (64 bit WoW report) ===
> ntoskrnl.exe:
> ntoskrnl.c:1707: Test succeeded inside todo block: got error 997
> driver_pnp.c:737: Test failed: expected IRP_MN_REMOVE_DEVICE
> ```
> Not exactly sure why this test got marked as succeeded when it had an error code 997

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/777#note_7715

[Bernhard Kölbl]

On Mon Sep  5 19:16:36 2022 +0000, Etaash Mathamsetty wrote:
> Not exactly sure why this test got marked as succeeded when it had an
> error code 997
> remove the todo_wine on that line?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/777#note_7718

[Etaash Mathamsetty (＠etaash.mathamsetty)]

On Mon Sep  5 20:12:02 2022 +0000, Bernhard K��lbl wrote:
> remove the todo_wine on that line?
> The problem is that I didn't modify anything related to that test

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/777#note_7741