[PATCH 0/1] MR173: tests/shader_runner: Remove a redundant vkd3d_test_pop_context().

[Zebediah Figura (＠zfigura)]

We already popped the context here.

Move the break inside the previous if to make control flow a little clearer.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/173

[PATCH 1/1] tests/shader_runner: Remove a redundant vkd3d_test_pop_context().

[Zebediah Figura]

From: Zebediah Figura <zfigura(a)codeweavers.com>

We already popped the context here.

Move the break inside the previous if to make control flow a little clearer.
---
 tests/shader_runner.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/shader_runner.c b/tests/shader_runner.c
index 58ed2d98..8e66948e 100644
--- a/tests/shader_runner.c
+++ b/tests/shader_runner.c
@@ -887,10 +887,10 @@ void run_shader_tests(struct shader_runner *runner, const struct shader_runner_o
 
             if (state != STATE_NONE)
                 vkd3d_test_pop_context();
-        }
 
-        if (!ret)
-            break;
+            if (!ret)
+                break;
+        }
 
         if (line[0] == '[')
         {
@@ -1088,8 +1088,6 @@ void run_shader_tests(struct shader_runner *runner, const struct shader_runner_o
         }
     }
 
-    vkd3d_test_pop_context();
-
 out:
     for (i = 0; i < runner->input_element_count; ++i)
         free(runner->input_elements[i].name);
-- 
GitLab

https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/173

[PATCH 0/1] MR173: tests/shader_runner: Remove a redundant vkd3d_test_pop_context(). - approved

[Giovanni Mascellani (＠giomasce)]

This merge request was approved by Giovanni Mascellani.
-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/173

[PATCH 0/1] MR173: tests/shader_runner: Remove a redundant vkd3d_test_pop_context(). - approved

[Henri Verbeet (＠hverbeet)]

This merge request was approved by Henri Verbeet.
-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/173