[PATCH 0/1] MR3424: msxml3: Accept ValidateOnParse property.

[Jactry Zeng (＠jactry)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3424

[PATCH 1/1] msxml3: Accept ValidateOnParse property.

[Jactry Zeng]

From: Jactry Zeng <jzeng(a)codeweavers.com>

---
 dlls/msxml3/domdoc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c
index f0420a517ea..9cce0108d09 100644
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -68,6 +68,7 @@ static const WCHAR PropertyResolveExternalsW[] = {'R','e','s','o','l','v','e','E
 static const WCHAR PropertyAllowXsltScriptW[] = {'A','l','l','o','w','X','s','l','t','S','c','r','i','p','t',0};
 static const WCHAR PropertyAllowDocumentFunctionW[] = {'A','l','l','o','w','D','o','c','u','m','e','n','t','F','u','n','c','t','i','o','n',0};
 static const WCHAR PropertyNormalizeAttributeValuesW[] = {'N','o','r','m','a','l','i','z','e','A','t','t','r','i','b','u','t','e','V','a','l','u','e','s',0};
+static const WCHAR PropertyValidateOnParse[] = L"ValidateOnParse";
 
 /* Anything that passes the test_get_ownerDocument()
  * tests can go here (data shared between all instances).
@@ -3192,6 +3193,7 @@ static HRESULT WINAPI domdoc_setProperty(
              lstrcmpiW(p, PropertyResolveExternalsW) == 0 ||
              lstrcmpiW(p, PropertyAllowXsltScriptW) == 0 ||
              lstrcmpiW(p, PropertyNormalizeAttributeValuesW) == 0 ||
+             lstrcmpiW(p, PropertyValidateOnParse) == 0 ||
              lstrcmpiW(p, PropertyAllowDocumentFunctionW) == 0)
     {
         /* Ignore */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3424

[Aida Jonikienė]

Aida Jonikienė (@DodoGTA) commented about dlls/msxml3/domdoc.c:
> static const WCHAR PropertyAllowXsltScriptW[] = {'A','l','l','o','w','X','s','l','t','S','c','r','i','p','t',0};
>  static const WCHAR PropertyAllowDocumentFunctionW[] = {'A','l','l','o','w','D','o','c','u','m','e','n','t','F','u','n','c','t','i','o','n',0};
>  static const WCHAR PropertyNormalizeAttributeValuesW[] = {'N','o','r','m','a','l','i','z','e','A','t','t','r','i','b','u','t','e','V','a','l','u','e','s',0};
> +static const WCHAR PropertyValidateOnParse[] = L"ValidateOnParse";
> This string definition looks different from the other definitions in the file

Maybe you should convert this library to use wide-string literals (or use the old string style for this change)?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3424#note_40418

[Nikolay Sivov (＠nsivov)]

Please add some tests for this. For example for default value of this property.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3424#note_40436