Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
Rémi Bernon (@rbernon) commented about dlls/opengl32/unix_wgl.c:
status = wow64_unmap_buffer( ptr, get_named_buffer_param( teb, params32->buffer, GL_BUFFER_MAP_LENGTH ), get_named_buffer_param( teb, params32->buffer, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_named_buffer64( args );
```suggestion:-7+0 struct glUnmapNamedBuffer_params params = { .teb = get_teb64(params32->teb), .buffer = params32->buffer, .ret = TRUE, }; NTSTATUS status; if (!(ptr = get_named_buffer_pointer( params.teb, params.buffer ))) return STATUS_SUCCESS; status = wow64_unmap_buffer( ptr, get_named_buffer_param( params.teb, params.buffer, GL_BUFFER_MAP_LENGTH ), get_named_buffer_param( params.teb, params.buffer, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_named_buffer64( ¶ms ); params32->ret = params.ret; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26527
participants (1)
-
Rémi Bernon