[PATCH 0/1] MR1994: ntoskrnl.exe/tests: Use loopback address in test_wsk_listen_socket.

[Jinoh Kang (＠iamahuman)]

Today, the driver_netio test server binds to the wildcard address
(0.0.0.0).  This may trigger a firewall alert on Windows 7, and the
alert UI window may interfere with user32:msg tests.

Fix this by binding to the loopback address (127.0.0.1) instead.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53891

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54202

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1994

[PATCH 1/1] ntoskrnl.exe/tests: Use loopback address in test_wsk_listen_socket.

[Jinoh Kang]

From: Jinoh Kang <jinoh.kang.kr(a)gmail.com>

Today, the driver_netio test server binds to the wildcard address
(0.0.0.0).  This may trigger a firewall alert on Windows 7, and the
alert UI window may interfere with user32:msg tests.

Fix this by binding to the loopback address (127.0.0.1) instead.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53891
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54202
---
 dlls/ntoskrnl.exe/tests/driver_netio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/ntoskrnl.exe/tests/driver_netio.c b/dlls/ntoskrnl.exe/tests/driver_netio.c
index e406f49eacb..9f9478d75b0 100644
--- a/dlls/ntoskrnl.exe/tests/driver_netio.c
+++ b/dlls/ntoskrnl.exe/tests/driver_netio.c
@@ -235,6 +235,7 @@ static void test_wsk_listen_socket(void)
     memset(&addr, 0, sizeof(addr));
     addr.sin_family = AF_INET;
     addr.sin_port = htons(SERVER_LISTEN_PORT);
+    addr.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
 
     IoReuseIrp(wsk_irp, STATUS_UNSUCCESSFUL);
     IoSetCompletionRoutine(wsk_irp, irp_completion_routine, &irp_complete_event, TRUE, TRUE, TRUE);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1994

[Jinoh Kang (＠iamahuman)]

Confirmed to trigger no firewall alerts in https://testbot.winehq.org/JobDetails.pl?Key=128585&s201=1&s202=1&s203=1#k20....

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1994#note_21306

[PATCH 0/1] MR1994: ntoskrnl.exe/tests: Use loopback address in test_wsk_listen_socket. - approved

[Paul Gofman (＠gofman)]

This merge request was approved by Paul Gofman.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1994