[PATCH 0/1] MR3095: ntoskrnl.exe: Implement a minimal Ke386QueryIoAccessMap() stub.

[Olivier F. R. Dierick (＠olivierfrdierick)]

Simply print a FIXME, instead of triggering the display of a terminal window to show 'call to unimplemented function' debugging info.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54380

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3095

[PATCH 1/1] ntoskrnl.exe: Implement a minimal Ke386QueryIoAccessMap() stub.

[Olivier F. R. Dierick]

From: "Olivier F. R. Dierick" <o.dierick(a)piezo-forte.be>

Simply print a FIXME, instead of triggering the display of a terminal window to show 'call to unimplemented function' debugging info.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54380
---
 dlls/ntoskrnl.exe/ntoskrnl.c        | 9 +++++++++
 dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c
index 407e7c4f5e9..7e3ad603549 100644
--- a/dlls/ntoskrnl.exe/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/ntoskrnl.c
@@ -3527,6 +3527,15 @@ BOOLEAN WINAPI Ke386IoSetAccessProcess(PEPROCESS *process, ULONG flag)
     return FALSE;
 }
 
+/*****************************************************
+ *           Ke386QueryIoAccessMap  (NTOSKRNL.EXE.@)
+ */
+BOOLEAN WINAPI Ke386QueryIoAccessMap(ULONG flag, PVOID buffer)
+{
+    FIXME("(%ld %p) stub\n", flag, buffer);
+    return FALSE;
+}
+
 /*****************************************************
  *           Ke386SetIoAccessMap  (NTOSKRNL.EXE.@)
  */
diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec
index 0b694b08de0..068806e52bc 100644
--- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec
+++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec
@@ -526,7 +526,7 @@
 @ stdcall KdRefreshDebuggerNotPresent()
 @ stub Ke386CallBios
 @ stdcall Ke386IoSetAccessProcess(ptr long)
-@ stub Ke386QueryIoAccessMap
+@ stdcall Ke386QueryIoAccessMap(long ptr)
 @ stdcall Ke386SetIoAccessMap(long ptr)
 @ stub KeAcquireInterruptSpinLock
 @ stdcall KeAcquireSpinLockAtDpcLevel(ptr)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3095

[Etaash Mathamsetty (＠etaash.mathamsetty)]

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/ntoskrnl.exe/ntoskrnl.c:
> return FALSE;
>  }
>
> +/*****************************************************
> + *           Ke386QueryIoAccessMap  (NTOSKRNL.EXE.@)
> + */
> +BOOLEAN WINAPI Ke386QueryIoAccessMap(ULONG flag, PVOID buffer)
> +{
> +    FIXME("(%ld %p) stub\n", flag, buffer);

I think this has to be %lu rather than %ld

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3095#note_36072

[Etaash Mathamsetty (＠etaash.mathamsetty)]

seems fine other than this

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3095#note_36073

[Olivier F. R. Dierick (＠olivierfrdierick)]

On Mon Jun 19 01:10:26 2023 +0000, Etaash Mathamsetty wrote:
> I think this has to be %lu rather than %ld
> Hello. I copy-pasted Ke386SetIoAccessMap() which has the same prototype arguments. Is it not better to keep it consistent with the other functions of the same family?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3095#note_36076