[PATCH 0/1] MR8536: msado15: Implement _Connection::get_version

[Alistair Leslie-Hughes (＠alesliehughes)]

Different windows version return differnt values.
MDAC 2.8 returns 2.8
Windows 10 returns 10.0

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8536

[PATCH 1/1] msado15: Implement _Connection::get_version

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

Different windows version return differnt values.
MDAC 2.8 returns 2.8
Windows 10 returns 10.0
---
 dlls/msado15/connection.c    | 6 ++++--
 dlls/msado15/tests/msado15.c | 6 ++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/dlls/msado15/connection.c b/dlls/msado15/connection.c
index 1eb2953057d..278ef1e76f4 100644
--- a/dlls/msado15/connection.c
+++ b/dlls/msado15/connection.c
@@ -269,8 +269,10 @@ static HRESULT WINAPI connection_put_ConnectionTimeout( _Connection *iface, LONG
 
 static HRESULT WINAPI connection_get_Version( _Connection *iface, BSTR *str )
 {
-    FIXME( "%p, %p\n", iface, str );
-    return E_NOTIMPL;
+    struct connection *connection = impl_from_Connection( iface );
+    TRACE( "%p, %p\n", connection, str );
+    *str = SysAllocString( L"2.8" );
+    return S_OK;
 }
 
 static HRESULT WINAPI connection_Close( _Connection *iface )
diff --git a/dlls/msado15/tests/msado15.c b/dlls/msado15/tests/msado15.c
index 95c73591c1f..5264cf710bc 100644
--- a/dlls/msado15/tests/msado15.c
+++ b/dlls/msado15/tests/msado15.c
@@ -1208,6 +1208,12 @@ if (0)   /* Crashes on windows */
     ok(hr == E_INVALIDARG, "Unexpected hr 0x%08lx\n", hr);
 }
 
+    str = NULL;
+    hr = _Connection_get_Version(connection, &str);
+    ok(hr == S_OK, "Failed to get state, hr 0x%08lx\n", hr);
+    ok(str != NULL, "got %p\n", str);
+    SysFreeString(str);
+
     state = -1;
     hr = _Connection_get_State(connection, &state);
     ok(hr == S_OK, "Failed to get state, hr 0x%08lx\n", hr);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8536